android: Use DisplayAndroid in java

android: Use DisplayAndroid in java

This replaces usage of java DeviceDisplayInfo with DisplayAndroid.
Unfortunately java code generally only pass around the Context instead
of WindowAndroid, so need to officially expose the DisplayAndroid.get
method to the public.

The rest is pretty easy. Only had to add getDIPScale.

BUG=625089
Committed: https://crrev.com/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df
Cr-Commit-Position: refs/heads/master@{#423806}

[boliu, 2016-10-06 18:28:04]

Description was changed from

==========
android: Use DisplayAndroid in java

This replaces usage of java DeviceDisplayInfo with DisplayAndroid.
Unfortunately java code generally only pass around the Context instead
of WindowAndroid, so need to officially expose the DisplayAndroid.get
method to the public.

BUG=625089
==========

to

==========
android: Use DisplayAndroid in java

This replaces usage of java DeviceDisplayInfo with DisplayAndroid.
Unfortunately java code generally only pass around the Context instead
of WindowAndroid, so need to officially expose the DisplayAndroid.get
method to the public.

The rest is pretty easy. Only had to add getDIPScale.

BUG=625089
==========

[boliu, 2016-10-06 18:28:10]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 18:29:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 19:13:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 19:13:49]

Dry run: This issue passed the CQ dry run.

[boliu, 2016-10-06 19:22:40]

boliu@chromium.org changed reviewers:
+ tedchoc@chromium.org

[boliu, 2016-10-06 19:22:40]

ptal

[Ted C, 2016-10-06 23:59:01]

lgtm

https://codereview.chromium.org/2394773006/diff/1/ui/android/java/src/org/chr...
File ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java (right):

https://codereview.chromium.org/2394773006/diff/1/ui/android/java/src/org/chr...
ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java:53: public
static DisplayAndroid get(Context context) {
javadoc now.  in particular, this is safe to call with an application context
right?  or does it need to be called with the activity/presentation context if
applicable?

[boliu, 2016-10-07 02:32:42]

https://codereview.chromium.org/2394773006/diff/1/ui/android/java/src/org/chr...
File ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java (right):

https://codereview.chromium.org/2394773006/diff/1/ui/android/java/src/org/chr...
ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java:53: public
static DisplayAndroid get(Context context) {
On 2016/10/06 23:59:01, Ted C wrote:
> javadoc now.  in particular, this is safe to call with an application context
> right?  or does it need to be called with the activity/presentation context if
> applicable?

Done. Yeah, any kind of context is fine, but I called out to prefer using
Activity or obtain DisplayAndroid from WindowAndroid.

[boliu, 2016-10-07 02:32:54]

The CQ bit was checked by boliu@chromium.org

[boliu, 2016-10-07 02:32:54]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2394773006/#ps20001
(title: "javadoc")

[commit-bot: I haz the power, 2016-10-07 02:33:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 04:11:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 04:11:23]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[boliu, 2016-10-07 04:30:47]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2016-10-07 04:30:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 05:18:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 05:18:18]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[boliu, 2016-10-07 05:28:27]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2016-10-07 05:28:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 06:08:55]

Description was changed from

==========
android: Use DisplayAndroid in java

This replaces usage of java DeviceDisplayInfo with DisplayAndroid.
Unfortunately java code generally only pass around the Context instead
of WindowAndroid, so need to officially expose the DisplayAndroid.get
method to the public.

The rest is pretty easy. Only had to add getDIPScale.

BUG=625089
==========

to

==========
android: Use DisplayAndroid in java

This replaces usage of java DeviceDisplayInfo with DisplayAndroid.
Unfortunately java code generally only pass around the Context instead
of WindowAndroid, so need to officially expose the DisplayAndroid.get
method to the public.

The rest is pretty easy. Only had to add getDIPScale.

BUG=625089
==========

[commit-bot: I haz the power, 2016-10-07 06:08:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-07 06:11:28]

Description was changed from

==========
android: Use DisplayAndroid in java

This replaces usage of java DeviceDisplayInfo with DisplayAndroid.
Unfortunately java code generally only pass around the Context instead
of WindowAndroid, so need to officially expose the DisplayAndroid.get
method to the public.

The rest is pretty easy. Only had to add getDIPScale.

BUG=625089
==========

to

==========
android: Use DisplayAndroid in java

This replaces usage of java DeviceDisplayInfo with DisplayAndroid.
Unfortunately java code generally only pass around the Context instead
of WindowAndroid, so need to officially expose the DisplayAndroid.get
method to the public.

The rest is pretty easy. Only had to add getDIPScale.

BUG=625089

Committed: https://crrev.com/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df
Cr-Commit-Position: refs/heads/master@{#423806}
==========

[commit-bot: I haz the power, 2016-10-07 06:11:30]

Patchset 2 (id:??) landed as
https://crrev.com/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df
Cr-Commit-Position: refs/heads/master@{#423806}