Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Issue 2394773005: Protobuf changes to support ARC++ kiosk policy. (Closed)

Created:
4 years, 2 months ago by peletskyi
Modified:
4 years, 2 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, alexchau, wenzhang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Protobuf changes to support ARC++ kiosk policy. BUG=634497 Committed: https://crrev.com/6567a8e17acbef02ab21824fb71b444cff2ffecd Cr-Commit-Position: refs/heads/master@{#423512}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M chrome/browser/chromeos/policy/proto/chrome_device_policy.proto View 3 chunks +29 lines, -1 line 1 comment Download

Messages

Total messages: 11 (5 generated)
peletskyi
Hi Nikita, can you please review the changes for kiosk?
4 years, 2 months ago (2016-10-06 12:49:31 UTC) #2
Nikita (slow)
lgtm https://codereview.chromium.org/2394773005/diff/1/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto (right): https://codereview.chromium.org/2394773005/diff/1/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto#newcode293 chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:293: // In the event this is the only ...
4 years, 2 months ago (2016-10-06 12:56:54 UTC) #4
Wen ZHANG
On 2016/10/06 12:56:54, Nikita (slow) wrote: > lgtm > > https://codereview.chromium.org/2394773005/diff/1/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto > File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto (right): ...
4 years, 2 months ago (2016-10-06 13:02:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394773005/1
4 years, 2 months ago (2016-10-06 13:26:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 13:52:36 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 13:54:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6567a8e17acbef02ab21824fb71b444cff2ffecd
Cr-Commit-Position: refs/heads/master@{#423512}

Powered by Google App Engine
This is Rietveld 408576698