Reorder clipboard data types in ui/base/clipboard/clipboard.h

Reorder clipboard data types in ui/base/clipboard/clipboard.h

The order in which the data types (formats) are listed in that file is
used when transferring Chrome's clipboard contents to the OS clipboard.
In some OSes, the order in which the data types are written to the
clipboard matters -- an earlier type may represent the data with more
accuracy than a later type.

This CL sets up a reasonable order, and fixes an image copying bug.

BUG=650724
TEST=manual, using the repro steps in the bug

Committed: https://crrev.com/736fcf0e7bef083610434b607e855df13cdccc79
Cr-Commit-Position: refs/heads/master@{#423349}

[pwnall, 2016-10-05 05:52:53]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 05:53:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2016-10-05 05:56:18]

Description was changed from

==========
Reorder clipboard data types in ui/base/clipboard/clipboard.h

The order in which the data types (formats) are listed in that file is
used when transferring Chrome's clipboard contents to the OS clipboard.
In some OSes, the order in which the data types are written to the
clipboard matters -- an earlier type may represent the data with more
accuracy than a later type.

This CL sets up a reasonable order, and fixes an image copying bug.

BUG=650724
==========

to

==========
Reorder clipboard data types in ui/base/clipboard/clipboard.h

The order in which the data types (formats) are listed in that file is
used when transferring Chrome's clipboard contents to the OS clipboard.
In some OSes, the order in which the data types are written to the
clipboard matters -- an earlier type may represent the data with more
accuracy than a later type.

This CL sets up a reasonable order, and fixes an image copying bug.

BUG=650724
TEST=manual, using the repro steps in the bug
==========

[pwnall, 2016-10-05 06:35:25]

PTAL?

[commit-bot: I haz the power, 2016-10-05 06:40:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 06:40:42]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-10-05 06:40:51]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-10-05 06:40:52]

LGTM

If it's not too much trouble, it might be good to sanity check the behavior on
Windows / Linux, e.g. image pasting into various apps still behaves sanely. Yay
for cross-platform things that have zero automated integration testing... sorry
for this legacy =(

[pwnall, 2016-10-05 20:48:54]

On 2016/10/05 06:40:52, dcheng wrote:
> LGTM
> 
> If it's not too much trouble, it might be good to sanity check the behavior on
> Windows / Linux, e.g. image pasting into various apps still behaves sanely.
Yay

Gah, this regresses Linux. I'll figure out how to fix things there and update
the CL.

Windows: Tried pasting images and URLs into Wordpad (URLs turn into text) and
Google Drive (everything works). Same behavior before and after the patch.

> for cross-platform things that have zero automated integration testing...
sorry
> for this legacy =(

If you share your wisdom with me, I'll (slowly) make things better. I promise to
look into tests, right after I dig myself out of the backlog of bugs!

[pwnall, 2016-10-06 00:00:46]

On 2016/10/05 20:48:54, pwnall wrote:
> Gah, this regresses Linux. I'll figure out how to fix things there and update
> the CL.

Actually, everything worked fine when I built Chrome on Ubuntu 14.04 and used it
against the 14.04 versions of Libre Office Writer and Abiword. I'm going to
blame things on me building Chromium incorrectly on Fedora.

[pwnall, 2016-10-06 00:00:50]

The CQ bit was checked by pwnall@chromium.org

[commit-bot: I haz the power, 2016-10-06 00:01:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-10-06 00:09:10]

On 2016/10/06 00:00:46, pwnall wrote:
> On 2016/10/05 20:48:54, pwnall wrote:
> > Gah, this regresses Linux. I'll figure out how to fix things there and
update
> > the CL.
> 
> Actually, everything worked fine when I built Chrome on Ubuntu 14.04 and used
it
> against the 14.04 versions of Libre Office Writer and Abiword. I'm going to
> blame things on me building Chromium incorrectly on Fedora.

Thanks for checking!

Sorry, I don't have any wisdom for testing: the entire area is a mess because
there are apps that randomly ignore the specification and do random stuff. For
example:
https://cs.chromium.org/chromium/src/ui/base/clipboard/clipboard_aurax11.cc?r...

So... in practice, this turns out to be:
Fix all the things you can. Test all things you can. And hope that there aren't
new bugs filed. =( =( =(

[commit-bot: I haz the power, 2016-10-06 00:11:23]

Description was changed from

==========
Reorder clipboard data types in ui/base/clipboard/clipboard.h

The order in which the data types (formats) are listed in that file is
used when transferring Chrome's clipboard contents to the OS clipboard.
In some OSes, the order in which the data types are written to the
clipboard matters -- an earlier type may represent the data with more
accuracy than a later type.

This CL sets up a reasonable order, and fixes an image copying bug.

BUG=650724
TEST=manual, using the repro steps in the bug
==========

to

==========
Reorder clipboard data types in ui/base/clipboard/clipboard.h

The order in which the data types (formats) are listed in that file is
used when transferring Chrome's clipboard contents to the OS clipboard.
In some OSes, the order in which the data types are written to the
clipboard matters -- an earlier type may represent the data with more
accuracy than a later type.

This CL sets up a reasonable order, and fixes an image copying bug.

BUG=650724
TEST=manual, using the repro steps in the bug
==========

[commit-bot: I haz the power, 2016-10-06 00:11:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-06 00:15:51]

Description was changed from

==========
Reorder clipboard data types in ui/base/clipboard/clipboard.h

The order in which the data types (formats) are listed in that file is
used when transferring Chrome's clipboard contents to the OS clipboard.
In some OSes, the order in which the data types are written to the
clipboard matters -- an earlier type may represent the data with more
accuracy than a later type.

This CL sets up a reasonable order, and fixes an image copying bug.

BUG=650724
TEST=manual, using the repro steps in the bug
==========

to

==========
Reorder clipboard data types in ui/base/clipboard/clipboard.h

The order in which the data types (formats) are listed in that file is
used when transferring Chrome's clipboard contents to the OS clipboard.
In some OSes, the order in which the data types are written to the
clipboard matters -- an earlier type may represent the data with more
accuracy than a later type.

This CL sets up a reasonable order, and fixes an image copying bug.

BUG=650724
TEST=manual, using the repro steps in the bug

Committed: https://crrev.com/736fcf0e7bef083610434b607e855df13cdccc79
Cr-Commit-Position: refs/heads/master@{#423349}
==========

[commit-bot: I haz the power, 2016-10-06 00:15:52]

Patchset 1 (id:??) landed as
https://crrev.com/736fcf0e7bef083610434b607e855df13cdccc79
Cr-Commit-Position: refs/heads/master@{#423349}

[pwnall, 2016-10-06 05:11:52]

On 2016/10/06 00:00:46, pwnall wrote:
> Actually, everything worked fine when I built Chrome on Ubuntu 14.04 and used
it
> against the 14.04 versions of Libre Office Writer and Abiword. I'm going to
> blame things on me building Chromium incorrectly on Fedora.

For posterity: my Fedora build environment was the culprit. "Copy image" doesn't
work on my Chromium built on Fedora even without this patch. I'll look into that
separately.