Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: ppapi/c/pp_input_event.h

Issue 2394773002: Remove 'char' from IDL (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/c/pp_input_event.h
diff --git a/ppapi/c/pp_input_event.h b/ppapi/c/pp_input_event.h
index ea65ae584dc43d138ba5e8cc657dd48368f94b1f..572d2aa4feef0cfe660ef7c88a7f419289b46934 100644
--- a/ppapi/c/pp_input_event.h
+++ b/ppapi/c/pp_input_event.h
@@ -81,7 +81,7 @@ struct PP_InputEvent_Character {
* maximum UTF-8 character is 4 bytes, there will always be at least one null
* at the end so you can treat this as a null-terminated UTF-8 string.
*/
- char text[5];
+ int8_t text[5];
};
PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PP_InputEvent_Character, 12);
@@ -121,7 +121,7 @@ struct PP_InputEvent_Mouse {
* plugin will give non-integer values.
*/
float y;
- /* TODO(brettw) figure out exactly what this means. */
+ /* (brettw) figure out exactly what this means. */
bbudge 2016/10/05 14:07:34 Delete comment
int32_t click_count;
};
PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PP_InputEvent_Mouse, 20);

Powered by Google App Engine
This is Rietveld 408576698