Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2394773002: Remove 'char' from IDL (Closed)

Created:
4 years, 2 months ago by Yeol Park
Modified:
4 years, 2 months ago
Reviewers:
raymes, bbudge, noelallen1
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, teravest+watch_chromium.org, bradnelson+warch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove 'char' from IDL We should just use int8_t or uint8_t instead of char in the IDL. BUG=255715 Committed: https://crrev.com/509e71d7781b783c01728263fe9ffd52123cdbe3 Cr-Commit-Position: refs/heads/master@{#423524}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove 'char' from IDL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M ppapi/api/pp_input_event.idl View 1 2 chunks +1 line, -3 lines 0 comments Download
M ppapi/api/ppb_gamepad.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/api/private/ppb_net_address_private.idl View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/pp_input_event.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/c/ppb_gamepad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/c/private/ppb_net_address_private.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Yeol Park
PTAL :) for Clean UP
4 years, 2 months ago (2016-10-05 04:59:20 UTC) #3
bbudge
lgtm w/comments https://codereview.chromium.org/2394773002/diff/1/ppapi/api/pp_input_event.idl File ppapi/api/pp_input_event.idl (right): https://codereview.chromium.org/2394773002/diff/1/ppapi/api/pp_input_event.idl#newcode115 ppapi/api/pp_input_event.idl:115: /* (brettw) figure out exactly what this ...
4 years, 2 months ago (2016-10-05 14:07:34 UTC) #4
Yeol Park
On 2016/10/05 14:07:34, bbudge wrote: > lgtm w/comments > > https://codereview.chromium.org/2394773002/diff/1/ppapi/api/pp_input_event.idl > File ppapi/api/pp_input_event.idl (right): ...
4 years, 2 months ago (2016-10-06 03:04:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394773002/20001
4 years, 2 months ago (2016-10-06 14:28:12 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 14:33:58 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 14:35:48 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/509e71d7781b783c01728263fe9ffd52123cdbe3
Cr-Commit-Position: refs/heads/master@{#423524}

Powered by Google App Engine
This is Rietveld 408576698