chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java - Issue 2394763004: Componentize parts of minidump uploading for use from WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java

Issue 2394763004: Componentize parts of minidump uploading for use from WebView. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests/DEPS ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java ('k') | components/minidump_uploader/BUILD.gn » ('j') | components/minidump_uploader/OWNERS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java

index ef017e7f9da037f524bff7f56a48a6f764a2c908..34a0721522c41961ec2d26b6fb89202b9c52eb3d 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java

@@ -179,7 +179,7 @@ public class MinidumpUploadServiceTest extends CrashTestCase {

// Create |MAX_TRIES_ALLOWED| callables.

final List<CountedMinidumpUploadCallable> callables =

new ArrayList<CountedMinidumpUploadCallable>();

- for (int i = 0; i < MinidumpUploadService.MAX_TRIES_ALLOWED; i++) {

+ for (int i = 0; i < CrashFileManager.MAX_TRIES_ALLOWED; i++) {

callables.add(new CountedMinidumpUploadCallable(

"chromium_renderer-111.dmp1" + (i > 0 ? ".try" + i : "") ,

MinidumpUploadCallable.UPLOAD_FAILURE,