components/minidump_uploader/OWNERS - Issue 2394763004: Componentize parts of minidump uploading for use from WebView.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/minidump_uploader/OWNERS

Issue 2394763004: Componentize parts of minidump uploading for use from WebView. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 mariakhomenko@chromium.org	1 mariakhomenko@chromium.org

2 tedchoc@chromium.org	2 isherman@chromium.org
	Ilya Sherman 2016/10/07 07:08:39 Please add some comments indicating the review exp Please add some comments indicating the review expectations -- I'm happy to review for crash upload mechanics changes, but am not comfortable approving for Java "readability". Maria is more inclined toward reviewing the Java best practices, and I think less inclined toward reviewing the crash upload mechanics (though I'm not sure if I'm correctly capturing her preferences).
OLD	NEW