Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 2394763002: Revert of Enable per thread heap on ServiceWorker (Closed)

Created:
4 years, 2 months ago by keishi
Modified:
4 years, 2 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable per thread heap on ServiceWorker (patchset #1 id:1 of https://codereview.chromium.org/2386523002/ ) Reason for revert: Caused crashes crbug.com/652058 crbug.com/651702 crbug.com/652001 crbug.com/652264 crbug.com/652183 crbug.com/652556 Original issue's description: > Enable per thread heap on ServiceWorker > > blink-dev PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc > > BUG=591606 > > Committed: https://crrev.com/5adb2db4a75dbaabace06728494946dd15630ebc > Cr-Commit-Position: refs/heads/master@{#422056} TBR=haraken@chromium.org,oilpan-reviews@chromium.org,nhiroki@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=591606 Committed: https://crrev.com/e12bb732e68991ae704c93b631c3ff06def24fb1 Cr-Commit-Position: refs/heads/master@{#423123}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
keishi
Created Revert of Enable per thread heap on ServiceWorker
4 years, 2 months ago (2016-10-05 04:32:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394763002/1
4 years, 2 months ago (2016-10-05 04:32:40 UTC) #3
haraken
LGTM
4 years, 2 months ago (2016-10-05 04:37:18 UTC) #4
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp: While running git apply --index -3 -p1; error: patch ...
4 years, 2 months ago (2016-10-05 06:37:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394763002/40001
4 years, 2 months ago (2016-10-05 07:21:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-05 10:08:21 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 10:09:48 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e12bb732e68991ae704c93b631c3ff06def24fb1
Cr-Commit-Position: refs/heads/master@{#423123}

Powered by Google App Engine
This is Rietveld 408576698