Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2394703003: Add deprecation messages to deprecated parts of the WebVR API. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index d53d32dbbd7c770fb3580619bb4a5e58c77dc271..a22211b8793e2feb0452887c3c0558f9c978935a 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -400,6 +400,12 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature)
case UseCounter::PaymentAddressCareOf:
return willBeRemoved("PaymentAddress.careOf", M56, "5728579069411328");
+ case UseCounter::VRDeprecatedFieldOfView:
+ return String::format("VREyeParameters.fieldOfView is deprecated and will be removed in %s. Prefer using the projection matrices provided by VRFrameData instead. See https://www.chromestatus.com/features/4532810371039232 for more details.", milestoneString(M57));
ddorwin 2016/10/05 21:32:43 WouldreplacedBy work? The chromestatus URL doesn'
billorr 2016/10/05 21:55:27 Sure - I can switch to that if we don't need the m
billorr 2016/10/05 22:47:55 Done.
+
+ case UseCounter::VRDeprecatedGetPose:
+ return String::format("VRDisplay.getPose() is deprecated and will be removed in %s. Prefer using VRDisplay.getFrameData() instead. See https://www.chromestatus.com/features/4532810371039232 for more details.", milestoneString(M57));
ddorwin 2016/10/05 21:32:43 ditto
billorr 2016/10/05 21:55:27 Acknowledged.
billorr 2016/10/05 22:47:55 Done.
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | third_party/WebKit/Source/modules/vr/NavigatorVR.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698