Add deprecation messages to deprecated parts of the WebVR API.

third_party/WebKit/Source/modules/vr/VRDisplay.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/vr/VRDisplay.h"
 
 #include "core/dom/DOMException.h"
 #include "core/dom/Fullscreen.h"
 #include "core/frame/UseCounter.h"
 #include "core/inspector/ConsoleMessage.h"
@@ skipping 86 matching lines @@
         return false;
 
     if (m_depthNear == m_depthFar)
         return false;
 
     return frameData->update(m_framePose, m_eyeParametersLeft, m_eyeParametersRight, m_depthNear, m_depthFar);
 }
 
 VRPose* VRDisplay::getPose()
 {
-    Document* document = m_navigatorVR->document();
-    if (document)
-        UseCounter::count(*document, UseCounter::VRDeprecatedGetPose);

[amp, 2016/10/05 20:43:14]

Do we not need this counter anymore?

[billorr, 2016/10/05 21:01:03]

I moved it to the IDL, so it will generate a deprecation message as well as
track the counter.

[billorr, 2016/10/05 22:47:55]

Done.

-
     updatePose();
 
     if (!m_framePose)
         return nullptr;
 
     VRPose* pose = VRPose::create();
     pose->setPose(m_framePose);
     return pose;
 }
 
@@ skipping 33 matching lines @@
 }
 
 void VRDisplay::cancelAnimationFrame(int id)
 {
     if (Document* document = m_navigatorVR->document())
         document->cancelAnimationFrame(id);
 }
 
 ScriptPromise VRDisplay::requestPresent(ScriptState* scriptState, const HeapVector<VRLayer>& layers)
 {
+    ExecutionContext* executionContext = scriptState->getExecutionContext();
+    String errorMessage;
+    if (executionContext->isSecureContext(errorMessage)) {

[ddorwin, 2016/10/05 21:32:43]

ditto

[billorr, 2016/10/05 21:55:27]

Acknowledged.

[billorr, 2016/10/05 22:47:55]

Done.

+        UseCounter::count(executionContext, UseCounter::VRRequestPresent);
+    } else {
+        UseCounter::count(executionContext,
+            UseCounter::VRRequestPresentInsecureOrigin);
+    }
+
     ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
     ScriptPromise promise = resolver->promise();
 
     // If the VRDisplay does not advertise the ability to present reject the request.
     if (!m_capabilities->canPresent()) {
         DOMException* exception = DOMException::create(InvalidStateError, "VRDisplay cannot present.");
         resolver->reject(exception);
         return promise;
     }
 
@@ skipping 194 matching lines @@
 {
     visitor->trace(m_navigatorVR);
     visitor->trace(m_capabilities);
     visitor->trace(m_stageParameters);
     visitor->trace(m_eyeParametersLeft);
     visitor->trace(m_eyeParametersRight);
     visitor->trace(m_layer);
 }
 
 } // namespace blink