Add deprecation messages to deprecated parts of the WebVR API.

third_party/WebKit/Source/modules/vr/NavigatorVR.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/vr/NavigatorVR.h"
 
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
@@ skipping 39 matching lines @@
     ScriptPromise promise = resolver->promise();
 
     Document* document = m_frame ? m_frame->document() : 0;
 
     if (!document || !controller()) {
         DOMException* exception = DOMException::create(InvalidStateError, "The object is no longer associated to a document.");
         resolver->reject(exception);
         return promise;
     }
 
+    ExecutionContext* executionContext = scriptState->getExecutionContext();
+    String errorMessage;
+    if (executionContext->isSecureContext(errorMessage)) {
+        UseCounter::count(*document, UseCounter::VRGetDisplays);
+    } else {
+        UseCounter::count(*document, UseCounter::VRGetDisplaysInsecureOrigin);
+    }
+
     UseCounter::count(*document, UseCounter::VRGetDisplays);

[amp, 2016/10/05 20:43:14]

Shouldn't this be removed since you are now counting it above?

Or do we want a count of all GetDisplay calls and then also a subset of that for
insecure ones?

[billorr, 2016/10/05 21:01:03]

Acknowledged.

[ddorwin, 2016/10/05 21:32:43]

We definitely don't want to call this twice (though it won't really affect data
since this is per page).

Unless we intend to rename the value, we should track all calls for this value.
That's also more useful since we're more likely to track all uses than to want
to look at two values and add them.

Thus:
count(VRGetDisplays)
if (insecure)
  count(VRGetDisplaysInsecureOrigin)

[billorr, 2016/10/05 21:55:27]

Acknowledged.

[billorr, 2016/10/05 22:47:55]

Done.

[billorr, 2016/10/05 22:47:55]

Done.

 
     controller()->getDisplays(resolver);
 
     return promise;
 }
 
 VRController* NavigatorVR::controller()
 {
     if (!frame())
         return 0;
@@ skipping 41 matching lines @@
 }
 
 void NavigatorVR::fireVREvent(VRDisplayEvent* event)
 {
     if (m_frame && m_frame->localDOMWindow()) {
         m_frame->localDOMWindow()->enqueueWindowEvent(event);
     }
 }
 
 } // namespace blink