Implement CSS luminance masking using skia SkLumaMaskXfermode class.

Implement CSS luminance masking using skia SkLumaMaskXfermode class.

BUG=289420
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158106

[Andrei Parvu, 2013-09-17 14:04:52]

In order to use CSS luminance masking, I've added the srcOver mode to the
SkLumaXfermode class (https://codereview.chromium.org/24078006/). This patch
sets the luminance srcOver mode in case we have the mask-source specified as
luminance.

[Andrei Parvu, 2013-09-19 08:51:32]

Could someone take a look at this patch, please? Thanks.

[eseidel, 2013-09-19 15:10:36]

This looks OK.  Is this feature guarded behind a runtime flag?

https://codereview.chromium.org/23947005/diff/6001/Source/core/platform/graph...
File Source/core/platform/graphics/skia/NativeImageSkia.cpp (right):

https://codereview.chromium.org/23947005/diff/6001/Source/core/platform/graph...
Source/core/platform/graphics/skia/NativeImageSkia.cpp:328: if
(context->drawLuminanceMask()) {
I believe blink style says {} are avoided when there is only one line in the
clause.

[Andrei Parvu, 2013-09-19 15:20:24]

On 2013/09/19 15:10:36, eseidel wrote:
> This looks OK.  Is this feature guarded behind a runtime flag?
> 

Yes, it's behind the webplatform experimental features flag.

>
https://codereview.chromium.org/23947005/diff/6001/Source/core/platform/graph...
> File Source/core/platform/graphics/skia/NativeImageSkia.cpp (right):
> 
>
https://codereview.chromium.org/23947005/diff/6001/Source/core/platform/graph...
> Source/core/platform/graphics/skia/NativeImageSkia.cpp:328: if
> (context->drawLuminanceMask()) {
> I believe blink style says {} are avoided when there is only one line in the
> clause.

I think it says it's up to the coder, but I'll change it :)

[eseidel, 2013-09-19 15:23:29]

lgtm

[commit-bot: I haz the power, 2013-09-19 15:23:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/andrei.prv@gmail.com/23947005/6001

[eseidel, 2013-09-19 15:23:43]

Don't worry about the {}, not worth the bother.

[commit-bot: I haz the power, 2013-09-19 15:23:50]

Failed to apply patch for
LayoutTests/css3/masking/mask-luminance-gradient-expected.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         LayoutTests/css3/masking/mask-luminance-gradient-expected.html
  Copied LayoutTests/css3/masking/mask-repeat-round-auto1-expected.html ->
LayoutTests/css3/masking/mask-luminance-gradient-expected.html
  patching file LayoutTests/css3/masking/mask-luminance-gradient-expected.html
  Hunk #1 FAILED at 13.
  1 out of 2 hunks FAILED -- saving rejects to file
LayoutTests/css3/masking/mask-luminance-gradient-expected.html.rej

Patch:   NR 
LayoutTests/css3/masking/mask-repeat-round-auto1-expected.html->LayoutTests/css3/masking/mask-luminance-gradient-expected.html
Index: LayoutTests/css3/masking/mask-luminance-gradient-expected.html
diff --git a/LayoutTests/css3/masking/mask-repeat-round-auto1-expected.html
b/LayoutTests/css3/masking/mask-luminance-gradient-expected.html
similarity index 77%
copy from LayoutTests/css3/masking/mask-repeat-round-auto1-expected.html
copy to LayoutTests/css3/masking/mask-luminance-gradient-expected.html
index
4e8a6fcae01f9901b112da28df1bd9745c59ae1f..c1024c8f3b6fa060d7c56e67f6b95a208a4d69b0
100644
--- a/LayoutTests/css3/masking/mask-repeat-round-auto1-expected.html
+++ b/LayoutTests/css3/masking/mask-luminance-gradient-expected.html
@@ -13,8 +13,9 @@
                 background-color: red;
                 border: 50px solid blue;
                 padding: 50px;
-                -webkit-mask-image: url(resources/circle.png);
-                -webkit-mask-size: 100px 79px;
+                -webkit-mask-image: linear-gradient(45deg, black, transparent
100%);
+                mask-source-type: alpha;
+                -webkit-mask-size: 200px auto;
                 -webkit-mask-repeat: repeat;
                 -webkit-mask-origin: border-box;
                 -webkit-mask-clip: border-box;
@@ -26,6 +27,6 @@
         <div id="back">
             <div id="front" />
         </div>
-    </body>
+            </body>
 </html>

[commit-bot: I haz the power, 2013-09-20 08:57:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/andrei.prv@gmail.com/23947005/17001

[commit-bot: I haz the power, 2013-09-20 09:20:49]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_blink_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-20 09:28:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/andrei.prv@gmail.com/23947005/31001

[commit-bot: I haz the power, 2013-09-20 09:41:36]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[commit-bot: I haz the power, 2013-09-20 11:29:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/andrei.prv@gmail.com/23947005/39001

[commit-bot: I haz the power, 2013-09-20 12:35:14]

Change committed as 158106