Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2394693002: Move parent of D3D surface window off the main GPU thread (Closed)

Created:
4 years, 2 months ago by stanisc
Modified:
4 years, 2 months ago
Reviewers:
jbauman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move parent of D3D surface window off the main GPU thread Currently the parent of D3D surface window is still created on the main thread which requires us to run UI message pump there. This change moves the creation and destruction of the parent window to the dedicated window thread. BUG=653181 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/be69cdd7300df9d72a94679632b4e05ea73f2bf2 Cr-Commit-Position: refs/heads/master@{#423293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -14 lines) Patch
M gpu/ipc/service/child_window_surface_win.h View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/ipc/service/child_window_surface_win.cc View 5 chunks +55 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
stanisc
Please take a look.
4 years, 2 months ago (2016-10-05 17:52:55 UTC) #8
jbauman
lgtm
4 years, 2 months ago (2016-10-05 20:26:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394693002/1
4 years, 2 months ago (2016-10-05 21:05:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 21:13:38 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 21:16:47 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be69cdd7300df9d72a94679632b4e05ea73f2bf2
Cr-Commit-Position: refs/heads/master@{#423293}

Powered by Google App Engine
This is Rietveld 408576698