Reland "components/arc: implement multi advertising"

Reland "components/arc: implement multi advertising"

This plumbs through multi advertising capabilities for the
instance. Instances can register and unregister advertisements.

Now with virtual destructors to prevent memory leaks in the
StructTraits conversion.

BUG=637171, 653338
TEST=use nrf connect on remote device and verify that packets
  registered from the instance are visible on the remote device,
  run tests with ASAN/LSAN turned on and verify there are no
  memory errors

Committed: https://crrev.com/be6d083433135e5435f3293b8604aecd8fd39290
Cr-Commit-Position: refs/heads/master@{#423672}

[Eric Caruso, 2016-10-06 19:00:49]

ejcaruso@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Eric Caruso, 2016-10-06 19:00:50]

PTAL. Sorry about the confusion.

https://codereview.chromium.org/2394683007/diff/1/components/arc/bluetooth/bl...
File components/arc/bluetooth/bluetooth_struct_traits.cc (right):

https://codereview.chromium.org/2394683007/diff/1/components/arc/bluetooth/bl...
components/arc/bluetooth/bluetooth_struct_traits.cc:34: virtual
~AdvertisementEntry() {}
This line and the other virtual destructors are the only things that have
changed from the patch that got reverted. When the
std::vector<std::unique_ptr<AdvertisementEntry>> was being destroyed in the
StructTraits converter, destructors were not called on members of subclasses of
AdvertisementEntry, which lead to leaks.

[Eric Caruso, 2016-10-06 19:01:21]

ejcaruso@chromium.org changed reviewers:
+ rickyz@chromium.org

[rickyz (no longer on Chrome), 2016-10-06 19:22:09]

Ah, totally missed that, lgtm

[Luis Héctor Chávez, 2016-10-06 19:23:53]

lgtm

https://codereview.chromium.org/2394683007/diff/1/components/arc/bluetooth/bl...
File components/arc/bluetooth/bluetooth_struct_traits.cc (right):

https://codereview.chromium.org/2394683007/diff/1/components/arc/bluetooth/bl...
components/arc/bluetooth/bluetooth_struct_traits.cc:34: virtual
~AdvertisementEntry() {}
On 2016/10/06 19:00:50, Eric Caruso wrote:
> This line and the other virtual destructors are the only things that have
> changed from the patch that got reverted. When the
> std::vector<std::unique_ptr<AdvertisementEntry>> was being destroyed in the
> StructTraits converter, destructors were not called on members of subclasses
of
> AdvertisementEntry, which lead to leaks.

The next time you reland something, can you please upload the revert as-is as
the first patchset, and then the fixes on patch set 2?

[Eric Caruso, 2016-10-06 19:53:39]

The CQ bit was checked by ejcaruso@chromium.org

[Eric Caruso, 2016-10-06 19:54:18]

ejcaruso@chromium.org changed reviewers:
+ steel@chromium.org

[commit-bot: I haz the power, 2016-10-06 19:54:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Rahul Chaturvedi, 2016-10-06 19:55:40]

rs-lgtm

[commit-bot: I haz the power, 2016-10-06 20:58:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-06 20:59:58]

Description was changed from

==========
Reland "components/arc: implement multi advertising"

This plumbs through multi advertising capabilities for the
instance. Instances can register and unregister advertisements.

Now with virtual destructors to prevent memory leaks in the
StructTraits conversion.

BUG=637171,653338
TEST=use nrf connect on remote device and verify that packets
  registered from the instance are visible on the remote device,
  run tests with ASAN/LSAN turned on and verify there are no
  memory errors
==========

to

==========
Reland "components/arc: implement multi advertising"

This plumbs through multi advertising capabilities for the
instance. Instances can register and unregister advertisements.

Now with virtual destructors to prevent memory leaks in the
StructTraits conversion.

BUG=637171,653338
TEST=use nrf connect on remote device and verify that packets
  registered from the instance are visible on the remote device,
  run tests with ASAN/LSAN turned on and verify there are no
  memory errors

Committed: https://crrev.com/be6d083433135e5435f3293b8604aecd8fd39290
Cr-Commit-Position: refs/heads/master@{#423672}
==========

[commit-bot: I haz the power, 2016-10-06 20:59:59]

Patchset 1 (id:??) landed as
https://crrev.com/be6d083433135e5435f3293b8604aecd8fd39290
Cr-Commit-Position: refs/heads/master@{#423672}