Switch analysis_server to use 'package:test'.

Switch analysis_server to use 'package:test'.

I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/de4d8b3a78f1f9b4e8773b081e2ab015b2bdf4e9

[Brian Wilkerson, 2016-10-06 15:44:09]

lgtm

https://codereview.chromium.org/2394683006/diff/1/pkg/analysis_server/test/ut...
File pkg/analysis_server/test/utils.dart (right):

https://codereview.chromium.org/2394683006/diff/1/pkg/analysis_server/test/ut...
pkg/analysis_server/test/utils.dart:7: void initializeTestEnvironment() {}
Why did you leave this empty method and invocations of it?

[scheglov, 2016-10-06 15:47:21]

Description was changed from

==========
Switch analysis_server to use 'package:test'.

I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Switch analysis_server to use 'package:test'.

I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/de4d8b3a78f1f9b4e8773b081e2ab015b2bdf4e9
==========

[scheglov, 2016-10-06 15:47:22]

Committed patchset #1 (id:1) manually as
de4d8b3a78f1f9b4e8773b081e2ab015b2bdf4e9 (presubmit successful).

[Paul Berry, 2016-10-06 15:55:45]

https://codereview.chromium.org/2394683006/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/server_options_test.dart (right):

https://codereview.chromium.org/2394683006/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/server_options_test.dart:22: baz: padded
Don't delete the end of line space here.  It's necessary for the test, because
the test is verifying that ServerOptions.fromContents properly strips the end of
line space.

https://codereview.chromium.org/2394683006/diff/1/pkg/analysis_server/test/ut...
File pkg/analysis_server/test/utils.dart (right):

https://codereview.chromium.org/2394683006/diff/1/pkg/analysis_server/test/ut...
pkg/analysis_server/test/utils.dart:7: void initializeTestEnvironment() {}
On 2016/10/06 15:44:09, Brian Wilkerson wrote:
> Why did you leave this empty method and invocations of it?

Agreed.  I had a similar comment about
https://codereview.chromium.org/2391423003/ which does not appear to have been
addressed.

[scheglov, 2016-10-06 17:17:08]

https://codereview.chromium.org/2394683006/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/server_options_test.dart (right):

https://codereview.chromium.org/2394683006/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/server_options_test.dart:22: baz: padded
On 2016/10/06 15:55:45, Paul Berry wrote:
> Don't delete the end of line space here.  It's necessary for the test, because
> the test is verifying that ServerOptions.fromContents properly strips the end
of
> line space.

OK

I changed the code to make it resilient to formatting in
https://codereview.chromium.org/2402483002