Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2394683004: switch to new skia blend mode enum class (Closed)

Created:
4 years, 2 months ago by caryclark
Modified:
4 years, 2 months ago
Reviewers:
dsinclair, reed1
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

switch to new skia blend mode enum class Skia's interface to transfer modes is not described by an enum instead of a class. R=reed@google.com, dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/aa6e8b555e113a3f91a49258ed83810abf0d4929

Patch Set 1 #

Patch Set 2 : update to skia with corrected blend mode implementation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 3 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
caryclark
4 years, 2 months ago (2016-10-05 19:38:43 UTC) #1
reed1
lgtm
4 years, 2 months ago (2016-10-05 19:46:32 UTC) #2
caryclark
not ready for landing yet; skia side was temporarily reverted
4 years, 2 months ago (2016-10-05 20:03:06 UTC) #5
dsinclair
lgtm
4 years, 2 months ago (2016-10-05 20:43:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394683004/20001
4 years, 2 months ago (2016-10-06 14:56:22 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 19:29:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/aa6e8b555e113a3f91a49258ed83810abf0d...

Powered by Google App Engine
This is Rietveld 408576698