Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2394683002: Update comments for AuthorizationExecuteWithPrivileges. (Closed)

Created:
4 years, 2 months ago by erikchen
Modified:
4 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update comments for AuthorizationExecuteWithPrivileges. As per discussion on crbug, no good replacement exists. Update the comments to indicate this. BUG=593133 Committed: https://crrev.com/1a2f872a1bcaa864308372fd94c502c309fdfc53 Cr-Commit-Position: refs/heads/master@{#423176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M base/mac/authorization_util.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/mac/app/AuthorizedInstall.m View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
erikchen
4 years, 2 months ago (2016-10-05 00:10:14 UTC) #3
Mark Mentovai
LGTM
4 years, 2 months ago (2016-10-05 15:25:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394683002/1
4 years, 2 months ago (2016-10-05 16:06:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 16:13:15 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 16:16:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a2f872a1bcaa864308372fd94c502c309fdfc53
Cr-Commit-Position: refs/heads/master@{#423176}

Powered by Google App Engine
This is Rietveld 408576698