Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2394663004: Fix DCHECK in network portal detector. (Closed)

Created:
4 years, 2 months ago by Alexander Alekseev
Modified:
4 years, 2 months ago
Reviewers:
oshima
CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECK in network portal detector. BUG=652908 TEST=none Committed: https://crrev.com/c301bd5c1ec7613f1ab618421b6eb015a649c2f2 Cr-Commit-Position: refs/heads/master@{#423028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/chromeos/net/network_portal_detector_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Alexander Alekseev
Please review.
4 years, 2 months ago (2016-10-05 00:17:28 UTC) #4
oshima
lgtm
4 years, 2 months ago (2016-10-05 00:41:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394663004/1
4 years, 2 months ago (2016-10-05 00:46:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 00:52:06 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 00:55:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c301bd5c1ec7613f1ab618421b6eb015a649c2f2
Cr-Commit-Position: refs/heads/master@{#423028}

Powered by Google App Engine
This is Rietveld 408576698