(tiny) Temporarily disable lock instrumentation

Temporarily disable lock instrumentation

Disable lock instrumentation pending a fix to avoid recursion.

BUG=620813, 652432
Committed: https://crrev.com/030a3da272a7d23ce08676dfa537e500d2b1ef89
Cr-Commit-Position: refs/heads/master@{#423281}

[manzagop (departed), 2016-10-04 20:09:36]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 20:10:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[manzagop (departed), 2016-10-04 20:10:44]

manzagop@chromium.org changed reviewers:
+ bcwhite@chromium.org

[manzagop (departed), 2016-10-04 20:10:44]

Hi Brian,
This is until a proper fix, so we can move forward with experimentation. Please
have a look!
Thanks,
Pierre

[bcwhite, 2016-10-04 20:31:00]

https://codereview.chromium.org/2394613002/diff/1/base/synchronization/lock_i...
File base/synchronization/lock_impl_posix.cc (left):

https://codereview.chromium.org/2394613002/diff/1/base/synchronization/lock_i...
base/synchronization/lock_impl_posix.cc:63:
base::debug::ScopedLockAcquireActivity lock_activity(this);
You can leave this.  It's only Windows that causes the recursion.

https://codereview.chromium.org/2394613002/diff/1/base/synchronization/lock_i...
File base/synchronization/lock_impl_win.cc (left):

https://codereview.chromium.org/2394613002/diff/1/base/synchronization/lock_i...
base/synchronization/lock_impl_win.cc:21: base::debug::ScopedLockAcquireActivity
lock_activity(this);
How about just commenting it out with a crbug reference?

[manzagop (departed), 2016-10-04 20:34:54]

Thanks! Another look?

https://codereview.chromium.org/2394613002/diff/1/base/synchronization/lock_i...
File base/synchronization/lock_impl_posix.cc (left):

https://codereview.chromium.org/2394613002/diff/1/base/synchronization/lock_i...
base/synchronization/lock_impl_posix.cc:63:
base::debug::ScopedLockAcquireActivity lock_activity(this);
On 2016/10/04 20:31:00, bcwhite wrote:
> You can leave this.  It's only Windows that causes the recursion.

Done.

https://codereview.chromium.org/2394613002/diff/1/base/synchronization/lock_i...
File base/synchronization/lock_impl_win.cc (left):

https://codereview.chromium.org/2394613002/diff/1/base/synchronization/lock_i...
base/synchronization/lock_impl_win.cc:21: base::debug::ScopedLockAcquireActivity
lock_activity(this);
On 2016/10/04 20:31:00, bcwhite wrote:
> How about just commenting it out with a crbug reference?

Done.

[manzagop (departed), 2016-10-04 21:10:37]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 21:11:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bcwhite, 2016-10-04 21:32:00]

lgtm

[manzagop (departed), 2016-10-04 21:38:56]

manzagop@chromium.org changed reviewers:
+ mark@chromium.org

[manzagop (departed), 2016-10-04 21:38:56]

Hi Mark!
Could you have an OWNERS' look?
Thanks!
Pierre

[commit-bot: I haz the power, 2016-10-04 23:32:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 23:32:50]

Dry run: This issue passed the CQ dry run.

[manzagop (departed), 2016-10-05 19:36:37]

Friendly ping, as I'm hoping to get this 1 liner in for tomorrow's canary.

[manzagop (departed), 2016-10-05 20:09:03]

manzagop@chromium.org changed reviewers:
+ thestig@chromium.org

[manzagop (departed), 2016-10-05 20:09:04]

Hi Lei!
I'm hoping to get this 1 liner into tomorrow's canary. Could you have an OWNERS'
look?
Thanks!
Pierre

[Mark Mentovai, 2016-10-05 20:38:39]

LGTM

[manzagop (departed), 2016-10-05 20:40:11]

Thanks for the review!

[manzagop (departed), 2016-10-05 20:40:21]

The CQ bit was checked by manzagop@chromium.org

[commit-bot: I haz the power, 2016-10-05 20:40:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 20:47:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 20:50:57]

Description was changed from

==========
Temporarily disable lock instrumentation

Disable lock instrumentation pending a fix to avoid recursion.

BUG=620813,652432
==========

to

==========
Temporarily disable lock instrumentation

Disable lock instrumentation pending a fix to avoid recursion.

BUG=620813,652432

Committed: https://crrev.com/030a3da272a7d23ce08676dfa537e500d2b1ef89
Cr-Commit-Position: refs/heads/master@{#423281}
==========

[commit-bot: I haz the power, 2016-10-05 20:50:58]

Patchset 2 (id:??) landed as
https://crrev.com/030a3da272a7d23ce08676dfa537e500d2b1ef89
Cr-Commit-Position: refs/heads/master@{#423281}