PNaCl Coordinator: Run StreamEnd RPC even if StreamChunk fails

ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

Index: ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
index b27bad16590df8d456eb87dc6da9a7bb93c9116d..8c2fd918e893346b5863b1ded287c721a3ad46c6 100644
--- a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
+++ b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
@@ -200,15 +200,20 @@ void PnaclTranslateThread::DoTranslate() {
                                              &params,
                                              &data[0],
                                              data.size())) {
-        TranslateFailed(ERROR_PNACL_LLC_INTERNAL,
-                        "Compile stream chunk failed.");
-        return;
+        if (llc_subprocess_->srpc_client()->GetLastError() !=

[jvoung (off chromium), 2013/09/09 23:24:28]

Could leave a comment about the difference in error handling.

[Derek Schuff, 2013/09/09 23:45:40]

Done.

+            NACL_SRPC_RESULT_APP_ERROR) {
+          TranslateFailed(ERROR_PNACL_LLC_INTERNAL,
+                          "Compile stream chunk failed.");
+          return;
+        }
+        break;
+      } else {
+        PLUGIN_PRINTF(("StreamChunk Successful\n"));
+        core->CallOnMainThread(
+            0,
+            coordinator_->GetCompileProgressCallback(data.size()),
+            PP_OK);
       }
-      PLUGIN_PRINTF(("StreamChunk Successful\n"));
-      core->CallOnMainThread(
-          0,
-          coordinator_->GetCompileProgressCallback(data.size()),
-          PP_OK);
     } else {
       NaClXMutexUnlock(&cond_mu_);
     }