Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2394593002: revert "SourceEventType added to LatencyInfo." (Closed)

Created:
4 years, 2 months ago by sahel
Modified:
4 years, 2 months ago
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, tdresser+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

revert "SourceEventType added to LatencyInfo." to see if it solves the content_browsertest timeouts on win64 official build. reverted cl: https://crrev.com/2317253005 TBR=jochen@chromium.org, sky@chromium.org BUG=650175, 622827 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e Cr-Commit-Position: refs/heads/master@{#423309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -383 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 7 chunks +9 lines, -20 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.h View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 10 chunks +19 lines, -22 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 5 chunks +5 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 4 chunks +3 lines, -58 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 4 chunks +11 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 chunk +0 lines, -26 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 16 chunks +19 lines, -23 lines 0 comments Download
M ui/events/blink/web_input_event_traits.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/events/blink/web_input_event_traits.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M ui/events/event.cc View 12 chunks +6 lines, -109 lines 0 comments Download
M ui/events/event_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M ui/events/ipc/latency_info_param_traits.cc View 4 chunks +0 lines, -6 lines 0 comments Download
M ui/events/ipc/latency_info_param_traits_macros.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/events/latency_info.h View 4 chunks +0 lines, -18 lines 0 comments Download
M ui/events/latency_info.cc View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
sahel
tdresser@chromium.org: Please review changes in
4 years, 2 months ago (2016-10-04 21:06:23 UTC) #7
sahel
alexmos@chromium.org: Please review changes in render_widget_host_view_guest.c lfg@chromium.org: Please review changes in browser_plugin_guest.cc jochen@chromium.org: Please review ...
4 years, 2 months ago (2016-10-04 21:10:20 UTC) #11
sahel
On 2016/10/04 21:10:20, sahel wrote: > mailto:alexmos@chromium.org: Please review changes in > render_widget_host_view_guest.c > > ...
4 years, 2 months ago (2016-10-04 21:13:11 UTC) #12
alexmos
frame_host/ LGTM. Description nits: it might be good to add a link to the CL ...
4 years, 2 months ago (2016-10-05 00:20:23 UTC) #13
tdresser
LGTM.
4 years, 2 months ago (2016-10-05 13:31:37 UTC) #14
tdresser
FYI, it's fine to "TBR" reverts. https://dev.chromium.org/developers/testing/commit-queue#TOC-Sending-a-TBR-patch-fast
4 years, 2 months ago (2016-10-05 13:33:50 UTC) #15
lfg
lgtm Feel free to TBR reverts like this.
4 years, 2 months ago (2016-10-05 17:34:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394593002/1
4 years, 2 months ago (2016-10-05 20:25:26 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 22:04:42 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 22:08:22 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e
Cr-Commit-Position: refs/heads/master@{#423309}

Powered by Google App Engine
This is Rietveld 408576698