Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2394573002: [Sync] Rename DataTypeState to ModelTypeState. (Closed)

Created:
4 years, 2 months ago by maxbogue
Modified:
4 years, 2 months ago
Reviewers:
skym
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Rename DataTypeState to ModelTypeState. BUG=651924 Committed: https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946 Cr-Commit-Position: refs/heads/master@{#422961}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -229 lines) Patch
M components/sync/api/fake_model_type_service.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M components/sync/api/fake_model_type_service.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download
M components/sync/api/metadata_batch.h View 2 chunks +6 lines, -6 lines 0 comments Download
M components/sync/api/metadata_batch.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/api/metadata_change_list.h View 2 chunks +6 lines, -6 lines 0 comments Download
M components/sync/core/activation_context.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync/core/model_type_processor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync/core/shared_model_type_processor.h View 4 chunks +5 lines, -5 lines 0 comments Download
M components/sync/core/shared_model_type_processor.cc View 16 chunks +29 lines, -29 lines 0 comments Download
M components/sync/core/shared_model_type_processor_unittest.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M components/sync/core/simple_metadata_change_list.h View 1 4 chunks +9 lines, -9 lines 0 comments Download
M components/sync/core/simple_metadata_change_list.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M components/sync/core/simple_metadata_change_list_unittest.cc View 1 4 chunks +12 lines, -12 lines 0 comments Download
M components/sync/core/test/fake_model_type_processor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/core_impl/test/fake_model_type_processor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/device_info/device_info_service.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M components/sync/device_info/device_info_service_unittest.cc View 1 8 chunks +11 lines, -11 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/model_type_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/model_type_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/model_type_registry_unittest.cc View 1 6 chunks +12 lines, -12 lines 0 comments Download
M components/sync/engine_impl/model_type_worker.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/engine_impl/model_type_worker.cc View 12 chunks +20 lines, -20 lines 0 comments Download
M components/sync/engine_impl/model_type_worker_unittest.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
D components/sync/protocol/data_type_state.proto View 1 chunk +0 lines, -33 lines 0 comments Download
A + components/sync/protocol/model_type_state.proto View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/protocol/protocol_sources.gni View 2 chunks +1 line, -1 line 0 comments Download
M components/sync/test/engine/mock_model_type_processor.h View 5 chunks +9 lines, -9 lines 0 comments Download
M components/sync/test/engine/mock_model_type_processor.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M components/sync/test/engine/mock_model_type_worker.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/test/engine/mock_model_type_worker.cc View 7 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
maxbogue
Sky, PTAL! This was mostly find/replace.
4 years, 2 months ago (2016-10-04 20:56:24 UTC) #8
skym
lgtm
4 years, 2 months ago (2016-10-04 21:43:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394573002/20001
4 years, 2 months ago (2016-10-04 21:47:10 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 22:17:59 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 22:23:09 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946
Cr-Commit-Position: refs/heads/master@{#422961}

Powered by Google App Engine
This is Rietveld 408576698