mustash: Fix crash when clicking on network in system tray

mustash: Fix crash when clicking on network in system tray

* Initialize ui::NetworkConnect during mash startup
* Provide a stub NetworkConnect::Delegate implementation

It still won't actually switch networks on the device (there are issues
talking to shill in lower-level code) but it's a step in the right direction.

BUG=644355
TEST=manual, click on network in system tray, no crash

Committed: https://crrev.com/0f9528ae987e59f9fc4c89b96d607dd441520b40
Cr-Commit-Position: refs/heads/master@{#423021}

[James Cook, 2016-10-04 22:38:55]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-10-04 22:39:10]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-10-04 22:39:11]

msw, please take a look.

[commit-bot: I haz the power, 2016-10-04 22:39:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-10-04 22:50:45]

lgtm with a nit

https://codereview.chromium.org/2394503003/diff/1/ash/mus/window_manager_appl...
File ash/mus/window_manager_application.cc (right):

https://codereview.chromium.org/2394503003/diff/1/ash/mus/window_manager_appl...
ash/mus/window_manager_application.cc:47: // NetworkConfig service.
nit: cite a bug?

https://codereview.chromium.org/2394503003/diff/1/ash/mus/window_manager_appl...
ash/mus/window_manager_application.cc:121: void
WindowManagerApplication::InitializeComponents() {
aside: too bad these have to become class members, but oh well.

https://codereview.chromium.org/2394503003/diff/1/ash/mus/window_manager_appl...
ash/mus/window_manager_application.cc:147: network_connect_delegate_.reset();
It's a bit odd that the window manager application would own a
NetworkConnect::Delegate, but I guess it's just temporary until your TODO above
is addressed.

[James Cook, 2016-10-04 23:37:29]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-10-04 23:37:29]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2394503003/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-10-04 23:38:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 00:37:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 00:39:28]

Description was changed from

==========
mustash: Fix crash when clicking on network in system tray

* Initialize ui::NetworkConnect during mash startup
* Provide a stub NetworkConnect::Delegate implementation

It still won't actually switch networks on the device (there are issues
talking to shill in lower-level code) but it's a step in the right direction.

BUG=644355
TEST=manual, click on network in system tray, no crash
==========

to

==========
mustash: Fix crash when clicking on network in system tray

* Initialize ui::NetworkConnect during mash startup
* Provide a stub NetworkConnect::Delegate implementation

It still won't actually switch networks on the device (there are issues
talking to shill in lower-level code) but it's a step in the right direction.

BUG=644355
TEST=manual, click on network in system tray, no crash

Committed: https://crrev.com/0f9528ae987e59f9fc4c89b96d607dd441520b40
Cr-Commit-Position: refs/heads/master@{#423021}
==========

[commit-bot: I haz the power, 2016-10-05 00:39:29]

Patchset 2 (id:??) landed as
https://crrev.com/0f9528ae987e59f9fc4c89b96d607dd441520b40
Cr-Commit-Position: refs/heads/master@{#423021}