Issue 23945003: Revert 221619 "Initial chrome.mdns API."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23945003: Revert 221619 "Initial chrome.mdns API." (Closed)

Created:
7 years, 3 months ago by henrika (OOO until Aug 14)

Modified:
7 years, 3 months ago

Reviewers:
justinlin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 221619 "Initial chrome.mdns API." > Initial chrome.mdns API. > Currently just implements the API layer which allows adding a listener and defines a manifest key to specify mdns service types to watch. > > BUG=280900 > TBR=erg > > Review URL: https://chromiumcodereview.appspot.com/23437015 TBR=justinlin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221668

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -591 lines)			Patch
D	trunk/src/chrome/browser/extensions/api/mdns/OWNERS	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/api/mdns/dns_sd_registry.h	View	1 chunk	+0 lines, -47 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/api/mdns/dns_sd_registry.cc	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/api/mdns/mdns_api.h	View	1 chunk	+0 lines, -80 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/api/mdns/mdns_api.cc	View	1 chunk	+0 lines, -154 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/api/mdns/mdns_apitest.cc	View	1 chunk	+0 lines, -120 lines	0 comments	Download
M	trunk/src/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser_extensions.gypi	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/common/extensions/api/_api_features.json	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/common/extensions/api/_permission_features.json	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	trunk/src/chrome/common/extensions/api/api.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	trunk/src/chrome/common/extensions/api/mdns.idl	View	1 chunk	+0 lines, -34 lines	0 comments	Download
M	trunk/src/chrome/common/extensions/permissions/api_permission.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/common/extensions/permissions/chrome_api_permissions.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/common/extensions/permissions/permission_set_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/renderer/extensions/event_bindings.cc	View	3 chunks	+1 line, -8 lines	0 comments	Download
M	trunk/src/chrome/renderer/resources/extensions/event.js	View	2 chunks	+2 lines, -6 lines	0 comments	Download
D	trunk/src/chrome/test/data/extensions/api_test/mdns/api/manifest.json	View	1 chunk	+0 lines, -8 lines	0 comments	Download
D	trunk/src/chrome/test/data/extensions/api_test/mdns/api/register_listener.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	trunk/src/chrome/test/data/extensions/api_test/mdns/api/register_listener.js	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	trunk/src/chrome/test/data/extensions/api_test/mdns/api/register_multiple_listeners.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	trunk/src/chrome/test/data/extensions/api_test/mdns/api/register_multiple_listeners.js	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	trunk/src/extensions/common/event_filtering_info.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/src/extensions/common/event_filtering_info.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	trunk/src/extensions/common/event_matcher.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/extensions/common/event_matcher.cc	View	3 chunks	+3 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

henrika (OOO until Aug 14)

7 years, 3 months ago (2013-09-06 10:09:35 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r221668.

Expand Messages | Collapse Messages