Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9558)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/file_tasks_unittest.cc

Issue 23945002: file_manager: Move non-binding code to c/b/chromeos/file_manager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/file_tasks_unittest.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/file_tasks_unittest.cc b/chrome/browser/chromeos/extensions/file_manager/file_tasks_unittest.cc
deleted file mode 100644
index 371d4889742ad0e3974d511b5a626e8e5de843b5..0000000000000000000000000000000000000000
--- a/chrome/browser/chromeos/extensions/file_manager/file_tasks_unittest.cc
+++ /dev/null
@@ -1,365 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/chromeos/extensions/file_manager/file_tasks.h"
-
-#include <algorithm>
-#include <utility>
-
-#include "base/prefs/pref_registry_simple.h"
-#include "base/prefs/testing_pref_service.h"
-#include "base/values.h"
-#include "chrome/browser/chromeos/drive/drive_app_registry.h"
-#include "chrome/browser/chromeos/drive/file_system_util.h"
-#include "chrome/browser/chromeos/extensions/file_manager/app_id.h"
-#include "chrome/browser/google_apis/drive_api_parser.h"
-#include "chrome/common/pref_names.h"
-#include "content/public/test/test_browser_thread_bundle.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace file_manager {
-namespace file_tasks {
-namespace {
-
-// Registers the default task preferences. Used for testing
-// ChooseAndSetDefaultTask().
-void RegisterDefaultTaskPreferences(TestingPrefServiceSimple* pref_service) {
- DCHECK(pref_service);
-
- pref_service->registry()->RegisterDictionaryPref(
- prefs::kDefaultTasksByMimeType);
- pref_service->registry()->RegisterDictionaryPref(
- prefs::kDefaultTasksBySuffix);
-}
-
-// Updates the default task preferences per the given dictionary values. Used
-// for testing ChooseAndSetDefaultTask.
-void UpdateDefaultTaskPreferences(TestingPrefServiceSimple* pref_service,
- const DictionaryValue& mime_types,
- const DictionaryValue& suffixes) {
- DCHECK(pref_service);
-
- pref_service->Set(prefs::kDefaultTasksByMimeType, mime_types);
- pref_service->Set(prefs::kDefaultTasksBySuffix, suffixes);
-}
-
-} // namespace
-
-TEST(FileManagerFileTasksTest,
- FullTaskDescriptor_NonDriveAppWithIconAndDefault) {
- FullTaskDescriptor full_descriptor(
- TaskDescriptor("app-id",
- TASK_TYPE_FILE_BROWSER_HANDLER,
- "action-id"),
- "task title",
- GURL("http://example.com/icon.png"),
- true /* is_default */);
-
- scoped_ptr<base::DictionaryValue> dictionary(
- full_descriptor.AsDictionaryValue());
- std::string task_id;
- EXPECT_TRUE(dictionary->GetString("taskId", &task_id));
- EXPECT_EQ("app-id|file|action-id", task_id);
-
- std::string icon_url;
- EXPECT_TRUE(dictionary->GetString("iconUrl", &icon_url));
- EXPECT_EQ("http://example.com/icon.png", icon_url);
-
- std::string title;
- EXPECT_TRUE(dictionary->GetString("title", &title));
- EXPECT_EQ("task title", title);
-
- bool is_default = false;
- EXPECT_TRUE(dictionary->GetBoolean("isDefault", &is_default));
- EXPECT_TRUE(is_default);
-}
-
-TEST(FileManagerFileTasksTest,
- FullTaskDescriptor_DriveAppWithoutIconAndNotDefault) {
- FullTaskDescriptor full_descriptor(
- TaskDescriptor("app-id",
- TASK_TYPE_DRIVE_APP,
- "action-id"),
- "task title",
- GURL(), // No icon URL.
- false /* is_default */);
-
- scoped_ptr<base::DictionaryValue> dictionary(
- full_descriptor.AsDictionaryValue());
- std::string task_id;
- EXPECT_TRUE(dictionary->GetString("taskId", &task_id));
- EXPECT_EQ("app-id|drive|action-id", task_id);
-
- std::string icon_url;
- EXPECT_FALSE(dictionary->GetString("iconUrl", &icon_url));
-
- std::string title;
- EXPECT_TRUE(dictionary->GetString("title", &title));
- EXPECT_EQ("task title", title);
-
- bool is_default = false;
- EXPECT_TRUE(dictionary->GetBoolean("isDefault", &is_default));
- EXPECT_FALSE(is_default);
-}
-
-TEST(FileManagerFileTasksTest, MakeTaskID) {
- EXPECT_EQ("app-id|file|action-id",
- MakeTaskID("app-id", TASK_TYPE_FILE_BROWSER_HANDLER, "action-id"));
- EXPECT_EQ("app-id|app|action-id",
- MakeTaskID("app-id", TASK_TYPE_FILE_HANDLER, "action-id"));
- EXPECT_EQ("app-id|drive|action-id",
- MakeTaskID("app-id", TASK_TYPE_DRIVE_APP, "action-id"));
-}
-
-TEST(FileManagerFileTasksTest, MakeDriveAppTaskId) {
- EXPECT_EQ("app-id|drive|open-with", MakeDriveAppTaskId("app-id"));
-}
-
-TEST(FileManagerFileTasksTest, TaskDescriptorToId) {
- EXPECT_EQ("app-id|file|action-id",
- TaskDescriptorToId(TaskDescriptor("app-id",
- TASK_TYPE_FILE_BROWSER_HANDLER,
- "action-id")));
-}
-
-TEST(FileManagerFileTasksTest, ParseTaskID_FileBrowserHandler) {
- TaskDescriptor task;
- EXPECT_TRUE(ParseTaskID("app-id|file|action-id", &task));
- EXPECT_EQ("app-id", task.app_id);
- EXPECT_EQ(TASK_TYPE_FILE_BROWSER_HANDLER, task.task_type);
- EXPECT_EQ("action-id", task.action_id);
-}
-
-TEST(FileManagerFileTasksTest, ParseTaskID_FileHandler) {
- TaskDescriptor task;
- EXPECT_TRUE(ParseTaskID("app-id|app|action-id", &task));
- EXPECT_EQ("app-id", task.app_id);
- EXPECT_EQ(TASK_TYPE_FILE_HANDLER, task.task_type);
- EXPECT_EQ("action-id", task.action_id);
-}
-
-TEST(FileManagerFileTasksTest, ParseTaskID_DriveApp) {
- TaskDescriptor task;
- EXPECT_TRUE(ParseTaskID("app-id|drive|action-id", &task));
- EXPECT_EQ("app-id", task.app_id);
- EXPECT_EQ(TASK_TYPE_DRIVE_APP, task.task_type);
- EXPECT_EQ("action-id", task.action_id);
-}
-
-TEST(FileManagerFileTasksTest, ParseTaskID_Legacy) {
- TaskDescriptor task;
- // A legacy task ID only has two parts. The task type should be
- // TASK_TYPE_FILE_BROWSER_HANDLER.
- EXPECT_TRUE(ParseTaskID("app-id|action-id", &task));
- EXPECT_EQ("app-id", task.app_id);
- EXPECT_EQ(TASK_TYPE_FILE_BROWSER_HANDLER, task.task_type);
- EXPECT_EQ("action-id", task.action_id);
-}
-
-TEST(FileManagerFileTasksTest, ParseTaskID_LegacyDrive) {
- TaskDescriptor task;
- // A legacy task ID only has two parts. For Drive app, the app ID is
- // prefixed with "drive-app:".
- EXPECT_TRUE(ParseTaskID("drive-app:app-id|action-id", &task));
- EXPECT_EQ("app-id", task.app_id);
- EXPECT_EQ(TASK_TYPE_DRIVE_APP, task.task_type);
- EXPECT_EQ("action-id", task.action_id);
-}
-
-TEST(FileManagerFileTasksTest, ParseTaskID_Invalid) {
- TaskDescriptor task;
- EXPECT_FALSE(ParseTaskID("invalid", &task));
-}
-
-TEST(FileManagerFileTasksTest, ParseTaskID_UnknownTaskType) {
- TaskDescriptor task;
- EXPECT_FALSE(ParseTaskID("app-id|unknown|action-id", &task));
-}
-
-TEST(FileManagerFileTasksTest, FindDriveAppTasks) {
- // For DriveAppRegistry, which checks CurrentlyOn(BrowserThread::UI).
- content::TestBrowserThreadBundle thread_bundle;
-
- // Foo.app can handle "text/plain" and "text/html"
- scoped_ptr<google_apis::AppResource> foo_app(new google_apis::AppResource);
- foo_app->set_product_url(
- GURL("https://chrome.google.com/webstore/detail/foo_app_id"));
- foo_app->set_application_id("foo_app_id");
- foo_app->set_name("Foo");
- foo_app->set_object_type("foo_object_type");
- ScopedVector<std::string> foo_mime_types;
- foo_mime_types.push_back(new std::string("text/plain"));
- foo_mime_types.push_back(new std::string("text/html"));
- foo_app->set_primary_mimetypes(&foo_mime_types);
-
- // Bar.app can only handle "text/plain".
- scoped_ptr<google_apis::AppResource> bar_app(new google_apis::AppResource);
- bar_app->set_product_url(
- GURL("https://chrome.google.com/webstore/detail/bar_app_id"));
- bar_app->set_application_id("bar_app_id");
- bar_app->set_name("Bar");
- bar_app->set_object_type("bar_object_type");
- ScopedVector<std::string> bar_mime_types;
- bar_mime_types.push_back(new std::string("text/plain"));
- bar_app->set_primary_mimetypes(&bar_mime_types);
-
- // Prepare DriveAppRegistry from Foo.app and Bar.app.
- ScopedVector<google_apis::AppResource> app_resources;
- app_resources.push_back(foo_app.release());
- app_resources.push_back(bar_app.release());
- google_apis::AppList app_list;
- app_list.set_items(&app_resources);
- drive::DriveAppRegistry drive_app_registry(NULL);
- drive_app_registry.UpdateFromAppList(app_list);
-
- // Find apps for a "text/plain" file. Foo.app and Bar.app should be found.
- PathAndMimeTypeSet path_mime_set;
- path_mime_set.insert(
- std::make_pair(
- drive::util::GetDriveMountPointPath().AppendASCII("foo.txt"),
- "text/plain"));
- std::vector<FullTaskDescriptor> tasks;
- FindDriveAppTasks(drive_app_registry,
- path_mime_set,
- &tasks);
- ASSERT_EQ(2U, tasks.size());
- // Sort the app IDs, as the order is not guaranteed.
- std::vector<std::string> app_ids;
- app_ids.push_back(tasks[0].task_descriptor().app_id);
- app_ids.push_back(tasks[1].task_descriptor().app_id);
- std::sort(app_ids.begin(), app_ids.end());
- // Confirm that both Foo.app and Bar.app are found.
- EXPECT_EQ("bar_app_id", app_ids[0]);
- EXPECT_EQ("foo_app_id", app_ids[1]);
-
- // Find apps for "text/plain" and "text/html" files. Only Foo.app should be
- // found.
- path_mime_set.clear();
- path_mime_set.insert(
- std::make_pair(
- drive::util::GetDriveMountPointPath().AppendASCII("foo.txt"),
- "text/plain"));
- path_mime_set.insert(
- std::make_pair(
- drive::util::GetDriveMountPointPath().AppendASCII("foo.html"),
- "text/html"));
- tasks.clear();
- FindDriveAppTasks(drive_app_registry,
- path_mime_set,
- &tasks);
- ASSERT_EQ(1U, tasks.size());
- // Confirm that both Foo.app is found.
- EXPECT_EQ("foo_app_id", tasks[0].task_descriptor().app_id);
-
- // Add a "text/plain" file not on Drive. No tasks should be found.
- path_mime_set.insert(
- std::make_pair(base::FilePath::FromUTF8Unsafe("not_on_drive.txt"),
- "text/plain"));
- tasks.clear();
- FindDriveAppTasks(drive_app_registry,
- path_mime_set,
- &tasks);
- // Confirm no tasks are found.
- ASSERT_TRUE(tasks.empty());
-}
-
-// Test that the right task is chosen from multiple choices per mime types
-// and file extensions.
-TEST(FileManagerFileTasksTest, ChooseAndSetDefaultTask_MultipleTasks) {
- TestingPrefServiceSimple pref_service;
- RegisterDefaultTaskPreferences(&pref_service);
-
- // Text.app and Nice.app were found for "foo.txt".
- TaskDescriptor text_app_task("text-app-id",
- TASK_TYPE_FILE_HANDLER,
- "action-id");
- TaskDescriptor nice_app_task("nice-app-id",
- TASK_TYPE_FILE_HANDLER,
- "action-id");
- std::vector<FullTaskDescriptor> tasks;
- tasks.push_back(FullTaskDescriptor(
- text_app_task,
- "Text.app",
- GURL("http://example.com/text_app.png"),
- false /* is_default */));
- tasks.push_back(FullTaskDescriptor(
- nice_app_task,
- "Nice.app",
- GURL("http://example.com/nice_app.png"),
- false /* is_default */));
- PathAndMimeTypeSet path_mime_set;
- path_mime_set.insert(std::make_pair(
- base::FilePath::FromUTF8Unsafe("foo.txt"),
- "text/plain"));
-
- // None of them should be chosen as default, as nothing is set in the
- // preferences.
- ChooseAndSetDefaultTask(pref_service, path_mime_set, &tasks);
- EXPECT_FALSE(tasks[0].is_default());
- EXPECT_FALSE(tasks[1].is_default());
-
- // Set Text.app as default for "text/plain" in the preferences.
- DictionaryValue empty;
- DictionaryValue mime_types;
- mime_types.SetStringWithoutPathExpansion(
- "text/plain",
- TaskDescriptorToId(text_app_task));
- UpdateDefaultTaskPreferences(&pref_service, mime_types, empty);
-
- // Text.app should be chosen as default.
- ChooseAndSetDefaultTask(pref_service, path_mime_set, &tasks);
- EXPECT_TRUE(tasks[0].is_default());
- EXPECT_FALSE(tasks[1].is_default());
-
- // Change it back to non-default for testing further.
- tasks[0].set_is_default(false);
-
- // Clear the preferences and make sure none of them are default.
- UpdateDefaultTaskPreferences(&pref_service, empty, empty);
- ChooseAndSetDefaultTask(pref_service, path_mime_set, &tasks);
- EXPECT_FALSE(tasks[0].is_default());
- EXPECT_FALSE(tasks[1].is_default());
-
- // Set Nice.app as default for ".txt" in the preferences.
- DictionaryValue suffixes;
- suffixes.SetStringWithoutPathExpansion(
- ".txt",
- TaskDescriptorToId(nice_app_task));
- UpdateDefaultTaskPreferences(&pref_service, empty, suffixes);
-
- // Now Nice.app should be chosen as default.
- ChooseAndSetDefaultTask(pref_service, path_mime_set, &tasks);
- EXPECT_FALSE(tasks[0].is_default());
- EXPECT_TRUE(tasks[1].is_default());
-}
-
-// Test that Files.app's internal file browser handler is chosen as default
-// even if nothing is set in the preferences.
-TEST(FileManagerFileTasksTest, ChooseAndSetDefaultTask_FallbackFileBrowser) {
- TestingPrefServiceSimple pref_service;
- RegisterDefaultTaskPreferences(&pref_service);
-
- // Files.app's internal file browser handler was found for "foo.txt".
- TaskDescriptor files_app_task(kFileManagerAppId,
- TASK_TYPE_FILE_BROWSER_HANDLER,
- "view-in-browser");
- std::vector<FullTaskDescriptor> tasks;
- tasks.push_back(FullTaskDescriptor(
- files_app_task,
- "View in browser",
- GURL("http://example.com/some_icon.png"),
- false /* is_default */));
- PathAndMimeTypeSet path_mime_set;
- path_mime_set.insert(std::make_pair(
- base::FilePath::FromUTF8Unsafe("foo.txt"),
- "text/plain"));
-
- // The internal file browser handler should be chosen as default, as it's a
- // fallback file browser handler.
- ChooseAndSetDefaultTask(pref_service, path_mime_set, &tasks);
- EXPECT_TRUE(tasks[0].is_default());
-}
-
-} // namespace file_tasks
-} // namespace file_manager.

Powered by Google App Engine
This is Rietveld 408576698