Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 23945002: file_manager: Move non-binding code to c/b/chromeos/file_manager (Closed)

Created:
7 years, 3 months ago by satorux1
Modified:
7 years, 3 months ago
Reviewers:
hidehiko, Lei Zhang
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, tfarina, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

file_manager: Move non-binding code to c/b/chromeos/file_manager To separate binding code and non-binding code: - chrome/browser/chromeos/extensions/file_manager: JS API bindings - chrome/browser/chromeos/file_manager: The gut Note that volume_manager* files are excluded as these are now actively being changed. BUG=273386 TEST=none R=hidehiko@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221334

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -5554 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_task_executor.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/action_choice_dialog.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/action_choice_dialog.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/app_id.h View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/desktop_notifications.h View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/desktop_notifications.cc View 1 chunk +0 lines, -388 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/desktop_notifications_browsertest.cc View 1 chunk +0 lines, -183 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/desktop_notifications_unittest.cc View 1 chunk +0 lines, -244 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/drive_test_util.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/drive_test_util.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/external_filesystem_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/file_browser_handlers.h View 1 chunk +0 lines, -85 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/file_browser_handlers.cc View 1 chunk +0 lines, -660 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/file_manager_installer.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/file_manager_installer.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/file_tasks.h View 1 1 chunk +0 lines, -313 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/file_tasks.cc View 1 1 chunk +0 lines, -560 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/file_tasks_unittest.cc View 1 1 chunk +0 lines, -365 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/file_watcher.h View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/file_watcher.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/file_watcher_unittest.cc View 1 chunk +0 lines, -157 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/fileapi_util.h View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/fileapi_util.cc View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/mime_util.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/mime_util.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/mime_util_unittest.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/mounted_disk_monitor.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/mounted_disk_monitor.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/open_util.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/open_util.cc View 1 chunk +0 lines, -337 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/open_with_browser.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/open_with_browser.cc View 1 chunk +0 lines, -239 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_util.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/select_file_dialog_util.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/select_file_dialog_util.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/url_util.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/url_util.cc View 1 chunk +0 lines, -135 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/url_util_unittest.cc View 1 chunk +0 lines, -135 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/zip_file_creator.h View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/zip_file_creator.cc View 1 chunk +0 lines, -126 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/action_choice_dialog.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/action_choice_dialog.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/app_id.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/desktop_notifications.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/desktop_notifications.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/desktop_notifications_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/file_manager/desktop_notifications_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/file_manager/drive_test_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/drive_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/file_manager/file_browser_handlers.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/file_manager_installer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/file_manager_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/file_manager/file_tasks.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/file_tasks.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/file_tasks_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/file_watcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/file_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/file_manager/file_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/file_manager/fileapi_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/fileapi_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/file_manager/mime_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/mime_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/file_manager/mime_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/file_manager/mounted_disk_monitor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/mounted_disk_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/file_manager/open_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/open_util.cc View 1 chunk +7 lines, -7 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/open_with_browser.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/open_with_browser.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/file_manager/select_file_dialog_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/select_file_dialog_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/file_manager/url_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/url_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/url_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/file_manager/zip_file_creator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/zip_file_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/platform_util_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/screenshot_taker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 3 chunks +31 lines, -31 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
satorux1
hidehiko: everything thestig: files outside of chrome/browser/chromeos, namely: chrome/browser/translate/translate_manager.cc chrome/browser/translate/translate_manager_unittest.cc chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc chrome/browser/ui/ash/screenshot_taker.cc chrome/browser/ui/views/select_file_dialog_extension.cc
7 years, 3 months ago (2013-09-04 07:58:08 UTC) #1
hidehiko
lgtm
7 years, 3 months ago (2013-09-04 08:42:01 UTC) #2
Lei Zhang
lgtm
7 years, 3 months ago (2013-09-04 22:07:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/23945002/1
7 years, 3 months ago (2013-09-04 22:10:44 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/browser/chromeos/file_manager/file_tasks_unittest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; A chrome/browser/chromeos/file_manager/file_tasks_unittest.cc ...
7 years, 3 months ago (2013-09-04 22:11:17 UTC) #5
satorux1
7 years, 3 months ago (2013-09-05 03:10:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r221334 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698