arc: OnClosedFromAndroid removes notifications as not by_user

ui/arc/notification/arc_notification_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/arc/notification/arc_notification_manager.h"
 
 #include <memory>
 #include <utility>
 
 #include "ash/common/system/toast/toast_manager.h"
@@ skipping 83 matching lines @@
 void ArcNotificationManager::OnNotificationRemoved(const mojo::String& key) {
   auto it = items_.find(key.get());
   if (it == items_.end()) {
     VLOG(3) << "Android requests to remove a notification (key: " << key
             << "), but it is already gone.";
     return;
   }
 
   std::unique_ptr<ArcNotificationItem> item = std::move(it->second);
   items_.erase(it);
-  item->OnClosedFromAndroid(true /* by_user */);
+  item->OnClosedFromAndroid(false /* by_user */);

[yoshiki, 2016/10/06 06:37:13]

Could you remove the "by_user" argument from
ArcNotificationItem::OnClosedFromAndroid() and to pass "false" directly from
inside of ArcNotificationItem::OnClosedFromAndroid()?

I think that's better than passing false from here.

[xiyuan, 2016/10/06 16:15:41]

Sounds good. Done.

 }
 
 void ArcNotificationManager::SendNotificationRemovedFromChrome(
     const std::string& key) {
   auto it = items_.find(key);
   if (it == items_.end()) {
     VLOG(3) << "Chrome requests to remove a notification (key: " << key
             << "), but it is already gone.";
     return;
   }
@@ skipping 123 matching lines @@
   ash::WmShell::Get()->toast_manager()->Show(
       ash::ToastData(data->id, data->text.To<base::string16>(), data->duration,
                      data->dismiss_text.To<base::string16>()));
 }
 
 void ArcNotificationManager::OnToastCancelled(mojom::ArcToastDataPtr data) {
   ash::WmShell::Get()->toast_manager()->Cancel(data->id);
 }
 
 }  // namespace arc