Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2394483002: Adding syncrhonization to PulseAudioOutputStream::SetVolume (Closed)

Created:
4 years, 2 months ago by o1ka
Modified:
4 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding syncrhonization to PulseAudioOutputStream::SetVolume to avoid a race with rendering callback (https://cs.chromium.org/chromium/src/media/audio/pulse/pulse_output.cc?sq=package:chromium&rcl=1475536681&l=148) BUG=285242 Committed: https://crrev.com/0704833d12e1e1bb47b24203b592833f3702334e Cr-Commit-Position: refs/heads/master@{#422845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M media/audio/pulse/pulse_output.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
o1ka
PTAL
4 years, 2 months ago (2016-10-04 12:08:04 UTC) #5
tommi (sloooow) - chröme
lgtm
4 years, 2 months ago (2016-10-04 12:56:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394483002/1
4 years, 2 months ago (2016-10-04 15:00:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 17:30:43 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 17:32:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0704833d12e1e1bb47b24203b592833f3702334e
Cr-Commit-Position: refs/heads/master@{#422845}

Powered by Google App Engine
This is Rietveld 408576698