Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2394473002: iframes with allowpaymentrequest attribute are allowed to make payment requests. (Closed)
Patch Set: Rebaselined tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 6e464c6aecf66892e4f2d2f857ff24075f0c9f93..a675e1d9dce0faadf5f55ccbef91befe73d88bca 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -1626,7 +1626,8 @@ LocalFrame* WebLocalFrameImpl::createChildFrame(
WebFrameOwnerProperties ownerProperties(
ownerElement->scrollingMode(), ownerElement->marginWidth(),
ownerElement->marginHeight(), ownerElement->allowFullscreen(),
- ownerElement->csp(), ownerElement->delegatedPermissions());
+ ownerElement->allowFullscreen(), ownerElement->csp(),
please use gerrit instead 2016/10/17 13:57:48 You seem to have passed in "allowFullscreen()" twi
pals 2016/10/18 04:39:21 Its a mistake. Messed up during rebase from patch
+ ownerElement->delegatedPermissions());
// FIXME: Using subResourceAttributeName as fallback is not a perfect
// solution. subResourceAttributeName returns just one attribute name. The
// element might not have the attribute, and there might be other attributes

Powered by Google App Engine
This is Rietveld 408576698