third_party/WebKit/Source/modules/payments/HTMLIFrameElementPayments.idl - Issue 2394473002: iframes with allowpaymentrequest attribute are allowed to make payment requests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/payments/HTMLIFrameElementPayments.idl

Issue 2394473002: iframes with allowpaymentrequest attribute are allowed to make payment requests. (Closed)

Patch Set: Rebaselined tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/browser-payment-api/#paymentrequest-and-iframes

	6 // https://w3c.github.io/browser-payment-api/#paymentrequest-and-iframes
	please use gerrit instead 2016/10/17 13:57:48 Please remove the duplicate line. Please remove the duplicate line. pals 2016/10/18 04:39:21 Messed up during rebase. Corrected now. Show quoted text On 2016/10/17 13:57:48, rouslan (slow 10.10-10.17) wrote: > Please remove the duplicate line. Messed up during rebase. Corrected now.
	7

	8 [

	9 RuntimeEnabled=PaymentRequest
	please use gerrit instead 2016/10/17 13:57:48 You don't need to specify 'ImplementedAs=HTMLIFram You don't need to specify 'ImplementedAs=HTMLIFrameElementPayments" here? pals 2016/10/18 04:39:21 As I see from existing blink code, if idl file nam Show quoted text On 2016/10/17 13:57:48, rouslan (slow 10.10-10.17) wrote: > You don't need to specify 'ImplementedAs=HTMLIFrameElementPayments" here? As I see from existing blink code, if idl file name and implementation file names are same, we do not need to specify ImplementedAs.
	10 ] partial interface HTMLIFrameElement {

	11 [CEReactions, Reflect] attribute boolean allowPaymentRequest;

	12 };

OLD	NEW