Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLIFrameElement.h

Issue 2394473002: iframes with allowpaymentrequest attribute are allowed to make payment requests. (Closed)
Patch Set: Rebase issues fixed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann <hausmann@kde.org> 4 * (C) 2000 Simon Hausmann <hausmann@kde.org>
5 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 10 matching lines...) Expand all
21 * 21 *
22 */ 22 */
23 23
24 #ifndef HTMLIFrameElement_h 24 #ifndef HTMLIFrameElement_h
25 #define HTMLIFrameElement_h 25 #define HTMLIFrameElement_h
26 26
27 #include "core/CoreExport.h" 27 #include "core/CoreExport.h"
28 #include "core/html/HTMLFrameElementBase.h" 28 #include "core/html/HTMLFrameElementBase.h"
29 #include "core/html/HTMLIFrameElementPermissions.h" 29 #include "core/html/HTMLIFrameElementPermissions.h"
30 #include "core/html/HTMLIFrameElementSandbox.h" 30 #include "core/html/HTMLIFrameElementSandbox.h"
31 #include "platform/Supplementable.h"
31 #include "public/platform/WebVector.h" 32 #include "public/platform/WebVector.h"
32 #include "public/platform/modules/permissions/WebPermissionType.h" 33 #include "public/platform/modules/permissions/WebPermissionType.h"
33 34
34 namespace blink { 35 namespace blink {
35 36
36 class CORE_EXPORT HTMLIFrameElement final : public HTMLFrameElementBase { 37 class CORE_EXPORT HTMLIFrameElement final
38 : public HTMLFrameElementBase,
39 public Supplementable<HTMLIFrameElement> {
37 DEFINE_WRAPPERTYPEINFO(); 40 DEFINE_WRAPPERTYPEINFO();
41 USING_GARBAGE_COLLECTED_MIXIN(HTMLIFrameElement);
38 42
39 public: 43 public:
40 DECLARE_NODE_FACTORY(HTMLIFrameElement); 44 DECLARE_NODE_FACTORY(HTMLIFrameElement);
41 DECLARE_VIRTUAL_TRACE(); 45 DECLARE_VIRTUAL_TRACE();
42 ~HTMLIFrameElement() override; 46 ~HTMLIFrameElement() override;
43 DOMTokenList* sandbox() const; 47 DOMTokenList* sandbox() const;
44 DOMTokenList* permissions() const; 48 DOMTokenList* permissions() const;
45 49
46 void sandboxValueWasSet(); 50 void sandboxValueWasSet();
47 void permissionsValueWasSet(); 51 void permissionsValueWasSet();
(...skipping 20 matching lines...) Expand all
68 } 72 }
69 void didLoadNonEmptyDocument() override { m_didLoadNonEmptyDocument = true; } 73 void didLoadNonEmptyDocument() override { m_didLoadNonEmptyDocument = true; }
70 bool isInteractiveContent() const override; 74 bool isInteractiveContent() const override;
71 75
72 ReferrerPolicy referrerPolicyAttribute() override; 76 ReferrerPolicy referrerPolicyAttribute() override;
73 77
74 bool allowFullscreen() const override { return m_allowFullscreen; } 78 bool allowFullscreen() const override { return m_allowFullscreen; }
75 79
76 AtomicString csp() const override { return m_csp; } 80 AtomicString csp() const override { return m_csp; }
77 81
82 bool allowPaymentRequest() const override { return m_allowPaymentRequest; }
please use gerrit instead 2016/10/18 14:04:49 I was under impression that this getter would live
pals 2016/10/19 05:09:53 I am trying to move "m_allowPaymentRequest" to HTM
haraken 2016/10/19 09:04:08 Nice catch! rouslan is right. We should put m_allo
83
78 const WebVector<WebPermissionType>& delegatedPermissions() const override { 84 const WebVector<WebPermissionType>& delegatedPermissions() const override {
79 return m_delegatedPermissions; 85 return m_delegatedPermissions;
80 } 86 }
81 87
82 bool initializePermissionsAttribute(); 88 bool initializePermissionsAttribute();
83 89
84 AtomicString m_name; 90 AtomicString m_name;
85 AtomicString m_csp; 91 AtomicString m_csp;
86 bool m_didLoadNonEmptyDocument; 92 bool m_didLoadNonEmptyDocument;
87 bool m_allowFullscreen; 93 bool m_allowFullscreen;
94 bool m_allowPaymentRequest;
please use gerrit instead 2016/10/18 14:04:49 Ditto
88 Member<HTMLIFrameElementSandbox> m_sandbox; 95 Member<HTMLIFrameElementSandbox> m_sandbox;
89 Member<HTMLIFrameElementPermissions> m_permissions; 96 Member<HTMLIFrameElementPermissions> m_permissions;
90 97
91 WebVector<WebPermissionType> m_delegatedPermissions; 98 WebVector<WebPermissionType> m_delegatedPermissions;
92 99
93 ReferrerPolicy m_referrerPolicy; 100 ReferrerPolicy m_referrerPolicy;
94 }; 101 };
95 102
96 } // namespace blink 103 } // namespace blink
97 104
98 #endif // HTMLIFrameElement_h 105 #endif // HTMLIFrameElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698