Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2394463002: headless: Fix two issues that are making the bot red (Closed)

Created:
4 years, 2 months ago by Sami
Modified:
4 years, 2 months ago
Reviewers:
altimin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Fix two issues that are making the bot red 1. Update to match new signature of WebContentsCreated. 2. Allow IO in the newly added renderer command prefix test. Committed: https://crrev.com/6198868c33601745c09867de71957906cc6c13d2 Cr-Commit-Position: refs/heads/master@{#422757}

Patch Set 1 #

Patch Set 2 : Allow IO in a different way #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M headless/lib/browser/headless_web_contents_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M headless/lib/headless_browser_browsertest.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Sami
4 years, 2 months ago (2016-10-04 10:34:16 UTC) #3
altimin
lgtm, thanks!
4 years, 2 months ago (2016-10-04 11:09:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394463002/1
4 years, 2 months ago (2016-10-04 11:16:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/272957)
4 years, 2 months ago (2016-10-04 11:24:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394463002/20001
4 years, 2 months ago (2016-10-04 11:36:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 11:45:02 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 11:48:47 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6198868c33601745c09867de71957906cc6c13d2
Cr-Commit-Position: refs/heads/master@{#422757}

Powered by Google App Engine
This is Rietveld 408576698