Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2394453002: Remove incorrect DCHECK in WebContentsImpl::UpdateTitle. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 397c14b9dbbf688fadb669dfc336582cdd7a1488..ec95918e642f32757c476122ba78261f6e688bcf 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -4621,11 +4621,10 @@ void WebContentsImpl::UpdateTitle(RenderFrameHost* render_frame_host,
// navigations in other processes, so we must use nav_entry_id.
// TODO(creis): Switch to use this as the default.
entry = new_entry;
- } else {
- // In modes that have no out-of-process iframes, nav_entry_id and page_id
- // should agree on which entry to update.
- DCHECK_EQ(entry, new_entry);
}
+ // (In modes that have no out-of-process iframes, nav_entry_id and page_id
+ // will usually agree on which entry to update, but may disagree if commits
+ // from a previous RFH have been ignored, resetting the RFH's nav_entry_id.)
// We can handle title updates when we don't have an entry in
// UpdateTitleForEntry, but only if the update is from the current RVH.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698