tight bounds optimization

tight bounds optimization

Add support for tight bounds to detect and return moveTo
followed by close or zero-length lineTo.

Also short circuit so that hard work is avoided when
the path bounds is also the tight bounds.

Avoid doing work if the bounds can be trivially computed.
Include naked moveTo coordinates in the tight bounds.

R=fmalita@chromium.org
BUG=skia:5555, skia:5553
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394443004

Committed: https://skia.googlesource.com/skia/+/61c21cdcc31081a1bd4a3a7480b482d135f7df33

[caryclark, 2016-10-05 18:07:43]

Description was changed from

==========
test 5555

These tests work fine.
Not sure how to repro
this bug, or perhaps,
the bug is already fixed.

R=fmalita@chromium.org
BUG=skia:5555
==========

to

==========
test 5555

These tests work fine.
Not sure how to repro
this bug, or perhaps,
the bug is already fixed.

R=fmalita@chromium.org
BUG=skia:5555
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394443004
==========

[caryclark, 2016-10-05 18:08:26]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 18:08:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caryclark, 2016-10-05 18:12:15]

Description was changed from

==========
test 5555

These tests work fine.
Not sure how to repro
this bug, or perhaps,
the bug is already fixed.

R=fmalita@chromium.org
BUG=skia:5555
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394443004
==========

to

==========
tight bounds optimization

Avoid doing work if the bounds can be trivially computed.
Include naked moveTo coordinates in the tight bounds.

R=fmalita@chromium.org
BUG=skia:5555
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394443004
==========

[caryclark, 2016-10-05 18:29:44]

Description was changed from

==========
tight bounds optimization

Avoid doing work if the bounds can be trivially computed.
Include naked moveTo coordinates in the tight bounds.

R=fmalita@chromium.org
BUG=skia:5555
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394443004
==========

to

==========
tight bounds optimization

Add support for tight bounds to detect and return moveTo
followed by close or zero-length lineTo.

Also short circuit so that hard work is avoided when
the path bounds is also the tight bounds.

Avoid doing work if the bounds can be trivially computed.
Include naked moveTo coordinates in the tight bounds.

R=fmalita@chromium.org
BUG=skia:5555, skia:5553
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394443004
==========

[caryclark, 2016-10-05 18:42:35]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 18:42:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-10-05 18:51:25]

https://codereview.chromium.org/2394443004/diff/20001/src/pathops/SkPathOpsTi...
File src/pathops/SkPathOpsTightBounds.cpp (right):

https://codereview.chromium.org/2394443004/diff/20001/src/pathops/SkPathOpsTi...
src/pathops/SkPathOpsTightBounds.cpp:30: wellBehaved &= !between(pts[0].fX,
pts[1].fX, pts[2].fX);
Doesn't between() == true => well behaved?

Maybe I'm misunderstanding the optimization, but that negation doesn't seem
right?

[commit-bot: I haz the power, 2016-10-05 19:02:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 19:02:18]

Dry run: This issue passed the CQ dry run.

[caryclark, 2016-10-05 19:16:35]

https://codereview.chromium.org/2394443004/diff/20001/src/pathops/SkPathOpsTi...
File src/pathops/SkPathOpsTightBounds.cpp (right):

https://codereview.chromium.org/2394443004/diff/20001/src/pathops/SkPathOpsTi...
src/pathops/SkPathOpsTightBounds.cpp:30: wellBehaved &= !between(pts[0].fX,
pts[1].fX, pts[2].fX);
On 2016/10/05 18:51:25, f(malita) wrote:
> Doesn't between() == true => well behaved?
> 
> Maybe I'm misunderstanding the optimization, but that negation doesn't seem
> right?

No, it is me who's logic is flipped. Fixed.

[caryclark, 2016-10-05 19:16:44]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 19:16:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-10-05 19:18:08]

lgtm

[commit-bot: I haz the power, 2016-10-05 19:41:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 19:41:41]

Dry run: This issue passed the CQ dry run.

[caryclark, 2016-10-05 19:52:59]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2016-10-05 19:53:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 20:23:02]

Description was changed from

==========
tight bounds optimization

Add support for tight bounds to detect and return moveTo
followed by close or zero-length lineTo.

Also short circuit so that hard work is avoided when
the path bounds is also the tight bounds.

Avoid doing work if the bounds can be trivially computed.
Include naked moveTo coordinates in the tight bounds.

R=fmalita@chromium.org
BUG=skia:5555, skia:5553
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394443004
==========

to

==========
tight bounds optimization

Add support for tight bounds to detect and return moveTo
followed by close or zero-length lineTo.

Also short circuit so that hard work is avoided when
the path bounds is also the tight bounds.

Avoid doing work if the bounds can be trivially computed.
Include naked moveTo coordinates in the tight bounds.

R=fmalita@chromium.org
BUG=skia:5555, skia:5553
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394443004

Committed:
https://skia.googlesource.com/skia/+/61c21cdcc31081a1bd4a3a7480b482d135f7df33
==========

[commit-bot: I haz the power, 2016-10-05 20:23:03]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/61c21cdcc31081a1bd4a3a7480b482d135f7df33