Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2394443004: tight bounds optimization (Closed)

Created:
4 years, 2 months ago by caryclark
Modified:
4 years, 2 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

tight bounds optimization Add support for tight bounds to detect and return moveTo followed by close or zero-length lineTo. Also short circuit so that hard work is avoided when the path bounds is also the tight bounds. Avoid doing work if the bounds can be trivially computed. Include naked moveTo coordinates in the tight bounds. R=fmalita@chromium.org BUG=skia:5555, skia:5553 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394443004 Committed: https://skia.googlesource.com/skia/+/61c21cdcc31081a1bd4a3a7480b482d135f7df33

Patch Set 1 #

Patch Set 2 : add tiny test #

Total comments: 2

Patch Set 3 : got the test wrong #

Patch Set 4 : fix reversed boolean logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -1 line) Patch
M src/pathops/SkPathOpsTightBounds.cpp View 1 2 3 3 chunks +43 lines, -1 line 0 comments Download
M tests/PathOpsTightBoundsTest.cpp View 1 2 3 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
caryclark
4 years, 2 months ago (2016-10-05 18:31:34 UTC) #6
f(malita)
https://codereview.chromium.org/2394443004/diff/20001/src/pathops/SkPathOpsTightBounds.cpp File src/pathops/SkPathOpsTightBounds.cpp (right): https://codereview.chromium.org/2394443004/diff/20001/src/pathops/SkPathOpsTightBounds.cpp#newcode30 src/pathops/SkPathOpsTightBounds.cpp:30: wellBehaved &= !between(pts[0].fX, pts[1].fX, pts[2].fX); Doesn't between() == true ...
4 years, 2 months ago (2016-10-05 18:51:25 UTC) #9
caryclark
https://codereview.chromium.org/2394443004/diff/20001/src/pathops/SkPathOpsTightBounds.cpp File src/pathops/SkPathOpsTightBounds.cpp (right): https://codereview.chromium.org/2394443004/diff/20001/src/pathops/SkPathOpsTightBounds.cpp#newcode30 src/pathops/SkPathOpsTightBounds.cpp:30: wellBehaved &= !between(pts[0].fX, pts[1].fX, pts[2].fX); On 2016/10/05 18:51:25, f(malita) ...
4 years, 2 months ago (2016-10-05 19:16:35 UTC) #12
f(malita)
lgtm
4 years, 2 months ago (2016-10-05 19:18:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394443004/60001
4 years, 2 months ago (2016-10-05 19:53:01 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 20:23:03 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/61c21cdcc31081a1bd4a3a7480b482d135f7df33

Powered by Google App Engine
This is Rietveld 408576698