ServiceWorker: Ensure that a resource list contains the main script

ServiceWorker: Ensure that a resource list contains the main script

A resource list retrieved from ServiceWorkerDatabase must contain the main
script. With this CL, ServiceWorkerDatabase checks it when retrieving resource
records from the database and notifies ServiceWorkerStorage of database
corruption if the records doesn't contain the main script. ServiceWorkerStorage
sweeps out the database in the case.

BUG=485900
Committed: https://crrev.com/106d4825d81c9340c295637398c80acd6bfd3496
Cr-Commit-Position: refs/heads/master@{#423071}

[nhiroki, 2016-10-04 05:02:13]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 05:02:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 05:24:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 05:24:06]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[nhiroki, 2016-10-04 05:29:46]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 05:29:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-10-04 05:34:30]

Patchset #2 (id:20001) has been deleted

[nhiroki, 2016-10-04 05:34:37]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 05:34:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-10-04 05:36:30]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org, shimazu@chromium.org

[nhiroki, 2016-10-04 05:36:31]

PTAL.

This CL addresses (1, 2) on my comment on the issue:
https://bugs.chromium.org/p/chromium/issues/detail?id=485900#c20

[commit-bot: I haz the power, 2016-10-04 06:00:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 06:00:43]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[falken, 2016-10-05 01:35:59]

https://codereview.chromium.org/2394443002/diff/40001/content/browser/service...
File content/browser/service_worker/service_worker_database_unittest.cc (right):

https://codereview.chromium.org/2394443002/diff/40001/content/browser/service...
content/browser/service_worker/service_worker_database_unittest.cc:1800:
resources.push_back(CreateResource(2, URL(origin, "/resource1"), 2016));
How does this simulate failure? Should it be "/resource2" to be more clear?

[nhiroki, 2016-10-05 02:11:32]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[nhiroki, 2016-10-05 02:11:48]

Thank you! Updated.

https://codereview.chromium.org/2394443002/diff/40001/content/browser/service...
File content/browser/service_worker/service_worker_database_unittest.cc (right):

https://codereview.chromium.org/2394443002/diff/40001/content/browser/service...
content/browser/service_worker/service_worker_database_unittest.cc:1800:
resources.push_back(CreateResource(2, URL(origin, "/resource1"), 2016));
On 2016/10/05 01:35:59, falken wrote:
> How does this simulate failure? Should it be "/resource2" to be more clear?

Oops! This is wrong and must be "resource2". Fixed. Sorry for confusing you...

(I slightly changed this part immediately before uploading the patchset without
confirming and it got broken...)

[commit-bot: I haz the power, 2016-10-05 02:11:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[falken, 2016-10-05 02:21:14]

lgtm

[commit-bot: I haz the power, 2016-10-05 03:51:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 03:51:57]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2016-10-05 03:53:46]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2016-10-05 03:53:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 03:58:52]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-10-05 04:01:05]

Description was changed from

==========
ServiceWorker: Ensure that a resource list contains the main script

A resource list retrieved from ServiceWorkerDatabase must contain the main
script. With this CL, ServiceWorkerDatabase checks it when retrieving resource
records from the database and notifies ServiceWorkerStorage of database
corruption if the records doesn't contain the main script. ServiceWorkerStorage
sweeps out the database in the case.

BUG=485900
==========

to

==========
ServiceWorker: Ensure that a resource list contains the main script

A resource list retrieved from ServiceWorkerDatabase must contain the main
script. With this CL, ServiceWorkerDatabase checks it when retrieving resource
records from the database and notifies ServiceWorkerStorage of database
corruption if the records doesn't contain the main script. ServiceWorkerStorage
sweeps out the database in the case.

BUG=485900

Committed: https://crrev.com/106d4825d81c9340c295637398c80acd6bfd3496
Cr-Commit-Position: refs/heads/master@{#423071}
==========

[commit-bot: I haz the power, 2016-10-05 04:01:08]

Patchset 3 (id:??) landed as
https://crrev.com/106d4825d81c9340c295637398c80acd6bfd3496
Cr-Commit-Position: refs/heads/master@{#423071}