[MD History] Make synced devices keyboard navigation consistent.

[MD History] Make synced devices keyboard navigation consistent.

This CL makes the synced devices use the same keyboard navigation
scheme as the history list.

BUG=651352
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9266bd31e78d69ba0edac40a1e5cce70d3740bde
Cr-Commit-Position: refs/heads/master@{#423090}

[calamity, 2016-10-04 03:44:36]

Description was changed from

==========
[MD History] Make synced devices keyboard navigation consistent.

This CL makes the synced devices use the same keyboard navigation
scheme as the history list.

BUG=651352
==========

to

==========
[MD History] Make synced devices keyboard navigation consistent.

This CL makes the synced devices use the same keyboard navigation
scheme as the history list.

BUG=651352
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-10-04 03:56:57]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 03:57:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2016-10-04 03:58:10]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[commit-bot: I haz the power, 2016-10-04 03:59:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 03:59:56]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tsergeant, 2016-10-04 06:09:02]

Needs a rebase.

What happens when the cards shuffle around? (ie, they update and change order,
or you hide one of them). Seems like focus gets lost.

https://codereview.chromium.org/2394433002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2394433002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_card.js:47: * @return
{Array<cr.ui.FocusRow>}
Nit: !Array<!cr.ui.FocusRow>

https://codereview.chromium.org/2394433002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/2394433002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.js:60: focusGrid_:
null,
/** @type {?cr.ui.FocusGrid} */

https://codereview.chromium.org/2394433002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.js:154:
updateFocusGrid_: function() {
/** @private */

[calamity, 2016-10-05 04:20:25]

https://codereview.chromium.org/2394433002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2394433002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_card.js:47: * @return
{Array<cr.ui.FocusRow>}
On 2016/10/04 06:09:02, tsergeant wrote:
> Nit: !Array<!cr.ui.FocusRow>

Done.

https://codereview.chromium.org/2394433002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/2394433002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.js:60: focusGrid_:
null,
On 2016/10/04 06:09:02, tsergeant wrote:
> /** @type {?cr.ui.FocusGrid} */

Done.

https://codereview.chromium.org/2394433002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.js:154:
updateFocusGrid_: function() {
On 2016/10/04 06:09:02, tsergeant wrote:
> /** @private */

Privated the rest of this file too.

https://codereview.chromium.org/2394433002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_manager.js (left):

https://codereview.chromium.org/2394433002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.js:261: }
We took this code from the old history page and it really doesn't give us
anything... Data-binding here is cleaner.

[calamity, 2016-10-05 04:20:31]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 04:20:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-10-05 04:39:59]

lgtm

https://codereview.chromium.org/2394433002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_manager.js (left):

https://codereview.chromium.org/2394433002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.js:261: }
On 2016/10/05 04:20:25, calamity wrote:
> We took this code from the old history page and it really doesn't give us
> anything... Data-binding here is cleaner.

The intention was that it would encourage Polymer to reuse old cards where
possible.

Agreed that we should change to the simpler version.

[commit-bot: I haz the power, 2016-10-05 06:18:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 06:18:05]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-10-05 06:24:44]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-10-05 06:24:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 06:29:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-05 06:32:51]

Description was changed from

==========
[MD History] Make synced devices keyboard navigation consistent.

This CL makes the synced devices use the same keyboard navigation
scheme as the history list.

BUG=651352
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Make synced devices keyboard navigation consistent.

This CL makes the synced devices use the same keyboard navigation
scheme as the history list.

BUG=651352
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9266bd31e78d69ba0edac40a1e5cce70d3740bde
Cr-Commit-Position: refs/heads/master@{#423090}
==========

[commit-bot: I haz the power, 2016-10-05 06:32:52]

Patchset 3 (id:??) landed as
https://crrev.com/9266bd31e78d69ba0edac40a1e5cce70d3740bde
Cr-Commit-Position: refs/heads/master@{#423090}