Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2394423002: bluetooth: Rename blink::mojom::WebBluetoothError (Closed)

Created:
4 years, 2 months ago by dougt
Modified:
4 years, 2 months ago
Reviewers:
Oliver Chang, ortuno
CC:
Aaron Boodman, abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, haraken, jam, mlamouri+watch-content_chromium.org, ortuno+watch_chromium.org, qsr+mojo_chromium.org, scheib+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Rename blink::mojom::WebBluetoothError Rename WebBluetoothError to WebBluetoothResult because it returns more than errors. BUG=599489 R=ortuno@chromium.org, ochang@chromium.org Committed: https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519 Cr-Commit-Position: refs/heads/master@{#424927}

Patch Set 1 #

Total comments: 2

Patch Set 2 : bluetooth: Rename blink::mojom::WebBluetoothError #

Patch Set 3 : bluetooth: Rename blink::mojom::WebBluetoothError #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -144 lines) Patch
M content/browser/bluetooth/bluetooth_device_chooser_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M content/browser/bluetooth/cache_query_result.h View 1 chunk +7 lines, -6 lines 0 comments Download
M content/browser/bluetooth/web_bluetooth_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/bluetooth/web_bluetooth_service_impl.cc View 1 2 22 chunks +59 lines, -57 lines 0 comments Download
M content/renderer/bluetooth/web_bluetooth_impl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/renderer/bluetooth/web_bluetooth_impl.cc View 6 chunks +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothError.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom View 1 2 4 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
ortuno
lgtm! https://codereview.chromium.org/2394423002/diff/1/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp File third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp (right): https://codereview.chromium.org/2394423002/diff/1/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp#newcode1 third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp:1: nit: I think you added this line by ...
4 years, 2 months ago (2016-10-07 05:32:52 UTC) #1
dougt
ochang: PTAL at third_party/W/p/p/m/b/web_bluetooth.mojom https://codereview.chromium.org/2394423002/diff/1/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp File third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp (right): https://codereview.chromium.org/2394423002/diff/1/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp#newcode1 third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp:1: On 2016/10/07 05:32:52, ortuno wrote: ...
4 years, 2 months ago (2016-10-07 05:44:39 UTC) #2
Oliver Chang
mojom lgtm
4 years, 2 months ago (2016-10-12 22:51:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394423002/40001
4 years, 2 months ago (2016-10-12 22:54:31 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-13 01:03:54 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 01:06:59 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519
Cr-Commit-Position: refs/heads/master@{#424927}

Powered by Google App Engine
This is Rietveld 408576698