Open MessagePumpLibevent's pipe with O_CLOEXEC

Open MessagePumpLibevent's pipe with O_CLOEXEC

This prevents the pipe's fds from being leaked into child processes.

TEST=git cl try
BUG=653930
Committed: https://crrev.com/f9c8562e55b669915faf87d8d7eda32ae62bf661
Cr-Commit-Position: refs/heads/master@{#423899}

[Luis Héctor Chávez, 2016-10-07 05:03:48]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 05:04:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 05:20:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 05:20:02]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Luis Héctor Chávez, 2016-10-07 15:38:32]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 15:38:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Luis Héctor Chávez, 2016-10-07 16:20:05]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[Luis Héctor Chávez, 2016-10-07 16:20:24]

Description was changed from

==========
Open MessagePump{Glib,Libevent}'s pipe with O_CLOEXEC

This prevents the pipe's fds from being leaked into child processes.

TEST=git cl try
BUG=
==========

to

==========
Open MessagePumpLibevent's pipe with O_CLOEXEC

This prevents the pipe's fds from being leaked into child processes.

TEST=git cl try
BUG=653930
==========

[commit-bot: I haz the power, 2016-10-07 16:20:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Luis Héctor Chávez, 2016-10-07 16:38:25]

lhchavez@chromium.org changed reviewers:
+ dcheng@chromium.org

[Luis Héctor Chávez, 2016-10-07 16:38:25]

PTAL

[commit-bot: I haz the power, 2016-10-07 17:27:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 17:27:28]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-10-07 17:38:45]

lgtm

[Luis Héctor Chávez, 2016-10-07 17:39:35]

The CQ bit was checked by lhchavez@chromium.org

[commit-bot: I haz the power, 2016-10-07 17:40:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 17:46:39]

Description was changed from

==========
Open MessagePumpLibevent's pipe with O_CLOEXEC

This prevents the pipe's fds from being leaked into child processes.

TEST=git cl try
BUG=653930
==========

to

==========
Open MessagePumpLibevent's pipe with O_CLOEXEC

This prevents the pipe's fds from being leaked into child processes.

TEST=git cl try
BUG=653930
==========

[commit-bot: I haz the power, 2016-10-07 17:46:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-07 17:50:10]

Description was changed from

==========
Open MessagePumpLibevent's pipe with O_CLOEXEC

This prevents the pipe's fds from being leaked into child processes.

TEST=git cl try
BUG=653930
==========

to

==========
Open MessagePumpLibevent's pipe with O_CLOEXEC

This prevents the pipe's fds from being leaked into child processes.

TEST=git cl try
BUG=653930

Committed: https://crrev.com/f9c8562e55b669915faf87d8d7eda32ae62bf661
Cr-Commit-Position: refs/heads/master@{#423899}
==========

[commit-bot: I haz the power, 2016-10-07 17:50:10]

Patchset 4 (id:??) landed as
https://crrev.com/f9c8562e55b669915faf87d8d7eda32ae62bf661
Cr-Commit-Position: refs/heads/master@{#423899}

[nasko, 2016-10-07 21:16:27]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2401863004/ by nasko@chromium.org.

The reason for reverting is: Reverting since it breaks NaCL tests.

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...

failures:
NaClBrowserTestNonSfiMode.Irt
NaClBrowserTestNonSfiMode.Messaging.