Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1934)

Issue 2394403002: [cleanup] Remove dead code from Variable and simplify PatternRewriter slightly (Closed)

Created:
4 years, 2 months ago by adamk
Modified:
4 years, 2 months ago
Reviewers:
gsathya
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Remove dead code from Variable and simplify PatternRewriter slightly Both bits of code were pointed out by our test coverage tools. R=gsathya@chromium.org Committed: https://crrev.com/707934cf9e5be32769538f0e2d84e3526666dbc4 Cr-Commit-Position: refs/heads/master@{#40095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -24 lines) Patch
M src/ast/variables.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast/variables.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +6 lines, -4 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
adamk
4 years, 2 months ago (2016-10-07 02:32:19 UTC) #1
gsathya
lgtm
4 years, 2 months ago (2016-10-07 18:45:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394403002/1
4 years, 2 months ago (2016-10-07 18:46:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 18:53:03 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 18:53:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/707934cf9e5be32769538f0e2d84e3526666dbc4
Cr-Commit-Position: refs/heads/master@{#40095}

Powered by Google App Engine
This is Rietveld 408576698