Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: Source/core/svg/animation/SVGSMILElement.h

Issue 23944012: [SVG] Avoid unnecessarily populating hashmap for repeat(n) event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/svg/animation/SVGSMILElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 155
156 // This represents conditions on elements begin or end list that need to be resolved on runtime 156 // This represents conditions on elements begin or end list that need to be resolved on runtime
157 // for example <animate begin="otherElement.begin + 8s; button.click" ... /> 157 // for example <animate begin="otherElement.begin + 8s; button.click" ... />
158 struct Condition { 158 struct Condition {
159 enum Type { 159 enum Type {
160 EventBase, 160 EventBase,
161 Syncbase, 161 Syncbase,
162 AccessKey 162 AccessKey
163 }; 163 };
164 164
165 Condition(Type, BeginOrEnd, const String& baseID, const String& name, SM ILTime offset); 165 Condition(Type, BeginOrEnd, const String& baseID, const String& name, SM ILTime offset, int repeat = -1);
166 Type m_type; 166 Type m_type;
167 BeginOrEnd m_beginOrEnd; 167 BeginOrEnd m_beginOrEnd;
168 String m_baseID; 168 String m_baseID;
169 String m_name; 169 String m_name;
170 SMILTime m_offset; 170 SMILTime m_offset;
171 int m_repeat;
171 RefPtr<Element> m_syncbase; 172 RefPtr<Element> m_syncbase;
172 RefPtr<ConditionEventListener> m_eventListener; 173 RefPtr<ConditionEventListener> m_eventListener;
173 }; 174 };
174 bool parseCondition(const String&, BeginOrEnd beginOrEnd); 175 bool parseCondition(const String&, BeginOrEnd beginOrEnd);
175 void parseBeginOrEnd(const String&, BeginOrEnd beginOrEnd); 176 void parseBeginOrEnd(const String&, BeginOrEnd beginOrEnd);
176 Element* eventBaseFor(const Condition&); 177 Element* eventBaseFor(const Condition&);
177 178
178 void disconnectConditions(); 179 void disconnectConditions();
179 180
180 // Event base timing 181 // Event base timing
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 247
247 inline SVGSMILElement* toSVGSMILElement(Element* element) 248 inline SVGSMILElement* toSVGSMILElement(Element* element)
248 { 249 {
249 ASSERT_WITH_SECURITY_IMPLICATION(!element || SVGSMILElement::isSMILElement(e lement)); 250 ASSERT_WITH_SECURITY_IMPLICATION(!element || SVGSMILElement::isSMILElement(e lement));
250 return static_cast<SVGSMILElement*>(element); 251 return static_cast<SVGSMILElement*>(element);
251 } 252 }
252 253
253 } 254 }
254 255
255 #endif // SVGSMILElement_h 256 #endif // SVGSMILElement_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/svg/animation/SVGSMILElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698