Issue 23944009: Move resources from drawable-mdpi to drawable at build time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23944009: Move resources from drawable-mdpi to drawable at build time. (Closed)

Created:
7 years, 3 months ago by newt (away)

Modified:
7 years, 3 months ago

Reviewers:
cjhopman, Yaron

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, Ted C, aurimas (slooooooooow), David Trainor- moved to gerrit

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move resources from drawable-mdpi to drawable at build time. This will allow us to keep images in drawable-mdpi in the source tree. BUG=289843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223443

Patch Set 1 #

Total comments: 1

Patch Set 2 : Chris's comment #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -1 line)			Patch
	M	build/android/gyp/process_resources.py	View	1	3 chunks	+29 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cjhopman

lgtm https://codereview.chromium.org/23944009/diff/1/build/android/gyp/process_resources.py File build/android/gyp/process_resources.py (right): https://codereview.chromium.org/23944009/diff/1/build/android/gyp/process_resources.py#newcode67 build/android/gyp/process_resources.py:67: del dst_components[dst_components.index('mdpi')] Maybe dst_components = [c for c ...

7 years, 3 months ago (2013-09-16 16:06:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/23944009/6001

7 years, 3 months ago (2013-09-16 18:54:45 UTC) #3

Message was sent while issue was closed.

Change committed as 223443

Expand Messages | Collapse Messages