Issue 23944007: [Files.app] Remove CommandUtil.getCommandPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23944007: [Files.app] Remove CommandUtil.getCommandPath() (Closed)

Created:
7 years, 3 months ago by yoshiki

Modified:
7 years, 3 months ago

Reviewers:
hirono

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Files.app] Remove CommandUtil.getCommandPath() This patch is almost a revert of crrev.com/219997. CommandUtil.getCommandPath() is no longer necessary because the patch for M30 has been merged successfully and the unavailable shortcut would been automatically removed. BUG=287597, 284921 TEST=manually tested R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222176

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -35 lines)			Patch
	M	chrome/browser/resources/file_manager/js/file_manager_commands.js	View		3 chunks	+3 lines, -35 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yoshiki

7 years, 3 months ago (2013-09-10 01:50:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r222176 (presubmit successful).

Expand Messages | Collapse Messages