Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1234)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 2394373002: Refactor ChromeActivity references out of TabModelSelectorImpl (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
index 4f11f594e745d5b0e4047b797a50fef39edf7dd4..26afef05a009f0f6f22c70b89660459d387f5f2f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
@@ -44,6 +44,7 @@ import org.chromium.chrome.browser.compositor.layouts.LayoutManagerDocument;
import org.chromium.chrome.browser.datausage.DataUseTabUIManager;
import org.chromium.chrome.browser.document.ChromeLauncherActivity;
import org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImpl;
+import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager;
import org.chromium.chrome.browser.metrics.PageLoadMetrics;
import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
import org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup;
@@ -274,7 +275,10 @@ public class CustomTabActivity extends ChromeActivity {
super.postInflationStartup();
TabPersistencePolicy persistencePolicy = new CustomTabTabPersistencePolicy(
getTaskId(), getSavedInstanceState() != null);
- setTabModelSelector(new TabModelSelectorImpl(this, persistencePolicy, false));
+
+ setTabModelSelector(new TabModelSelectorImpl(this, this, getFullscreenManager(),
+ persistencePolicy, false));
+
setTabCreators(
new CustomTabCreator(
this, getWindowAndroid(), false,
@@ -344,11 +348,10 @@ public class CustomTabActivity extends ChromeActivity {
getTabModelSelector().getModel(false).addTab(mMainTab, 0, mMainTab.getLaunchType());
}
- ToolbarControlContainer controlContainer = (ToolbarControlContainer) findViewById(
- R.id.control_container);
LayoutManagerDocument layoutDriver = new CustomTabLayoutManager(getCompositorViewHolder());
initializeCompositorContent(layoutDriver, findViewById(R.id.url_bar),
- (ViewGroup) findViewById(android.R.id.content), controlContainer);
+ (ViewGroup) findViewById(android.R.id.content),
+ (ToolbarControlContainer) findViewById(R.id.control_container));
mFindToolbarManager = new FindToolbarManager(this,
getToolbarManager().getActionModeController().getActionModeCallback());
if (getContextualSearchManager() != null) {
@@ -364,7 +367,6 @@ public class CustomTabActivity extends ChromeActivity {
}
});
- getFullscreenManager().setTab(mMainTab);
mCustomTabContentHandler = new CustomTabContentHandler() {
@Override
public void loadUrlAndTrackFromTimestamp(LoadUrlParams params, long timestamp) {
@@ -851,4 +853,11 @@ public class CustomTabActivity extends ChromeActivity {
}
return url;
}
+
+ @Override
+ protected ChromeFullscreenManager createFullscreenManager() {
+ return new ChromeFullscreenManager(this,
+ (ToolbarControlContainer) findViewById(R.id.control_container),
+ getControlContainerHeightResource(), true);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698