Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2394343003:
Use FileDescriptorWatcher in HidConnectionLinux::FileThreadHelper. (Closed)
|
Created:
4 years, 2 months ago by fdoray Modified:
4 years, 2 months ago Reviewers:
Ken Rockot(use gerrit already) CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse FileDescriptorWatcher in HidConnectionLinux::FileThreadHelper.
This allows HidConnectionLinux::FileThreadHelper to be used from
any thread that instantiates a FileDescriptorWatcher (not just threads
that run a MessageLoopForIO). This will facilitate the migration of
BrowserThreads to base/task_scheduler.
BUG=645114
Committed: https://crrev.com/150be4b2b4d10d0bd5a552ff76802b2d15950ec6
Cr-Commit-Position: refs/heads/master@{#424504}
Patch Set 1 #Patch Set 2 : fix build error #Patch Set 3 : fix build error #Messages
Total messages: 20 (15 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
fdoray@chromium.org changed reviewers: + rockot@chromium.org
PTAL
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Use FileDescriptorWatcher in HidConnectionLinux::FileThreadHelper. This allows HidConnectionLinux::FileThreadHelper to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 ========== to ========== Use FileDescriptorWatcher in HidConnectionLinux::FileThreadHelper. This allows HidConnectionLinux::FileThreadHelper to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 Committed: https://crrev.com/150be4b2b4d10d0bd5a552ff76802b2d15950ec6 Cr-Commit-Position: refs/heads/master@{#424504} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/150be4b2b4d10d0bd5a552ff76802b2d15950ec6 Cr-Commit-Position: refs/heads/master@{#424504} |
