Convert IJS_Runtime to CPDFSDK_FormFillEnvironment

fpdfsdk/cpdfsdk_interform.cpp

Index: fpdfsdk/cpdfsdk_interform.cpp
diff --git a/fpdfsdk/cpdfsdk_interform.cpp b/fpdfsdk/cpdfsdk_interform.cpp
index 2cbdae96d43bfd1277e245dc2562be4fc0721a89..69698ea421aeef1c03eda4918cced5a574c9b590 100644
--- a/fpdfsdk/cpdfsdk_interform.cpp
+++ b/fpdfsdk/cpdfsdk_interform.cpp
@@ -236,8 +236,6 @@ void CPDFSDK_InterForm::OnCalculate(CPDF_FormField* pFormField) {
   }
 
   IJS_Runtime* pRuntime = m_pFormFillEnv->GetJSRuntime();
-  pRuntime->SetReaderDocument(m_pFormFillEnv->GetSDKDocument());

[Tom Sepez, 2016/10/11 16:17:13]

Remind me again why we think documents are 1:1 with IJS_Runtimes.

[dsinclair, 2016/10/11 17:37:45]

The GetJSRuntime method, if it doesn't already exist, creates the JSRuntime and
passes |this| as the environment for the runtime. The |CPDFSDK_Document| is only
created in the env, so they have to be 1:1. So, getting the sdk document out of
the environment and putting it into the |SetReaderDocument| should be the same
as just getting it from the environment.

Does that make sense? (It's possible I'm off base here ....)

-
   int nSize = m_pInterForm->CountFieldsInCalculationOrder();
   for (int i = 0; i < nSize; i++) {
     CPDF_FormField* pField = m_pInterForm->GetFieldInCalculationOrder(i);
@@ -286,8 +284,6 @@ CFX_WideString CPDFSDK_InterForm::OnFormat(CPDF_FormField* pFormField,
   }
 
   IJS_Runtime* pRuntime = m_pFormFillEnv->GetJSRuntime();
-  pRuntime->SetReaderDocument(m_pFormFillEnv->GetSDKDocument());

[dsinclair, 2016/10/11 17:37:45]

Same reasoning as above.

-
   if (pFormField->GetFieldType() == FIELDTYPE_COMBOBOX &&
       pFormField->CountSelectedItems() > 0) {
     int index = pFormField->GetSelectedIndex(0);