Don't prompt for download location on Android

chrome/browser/download/download_prefs.cc

Index: chrome/browser/download/download_prefs.cc
diff --git a/chrome/browser/download/download_prefs.cc b/chrome/browser/download/download_prefs.cc
index 1b85c84815062268c99020f1db0d395cd386a21e..635e5567b2dc18775f2ee5e522f5956f584c834d 100644
--- a/chrome/browser/download/download_prefs.cc
+++ b/chrome/browser/download/download_prefs.cc
@@ -156,7 +156,12 @@ DownloadPrefs::DownloadPrefs(Profile* profile) : profile_(profile) {
     prefs->SetBoolean(prefs::kDownloadDirUpgraded, true);
   }
 
+// Ignore "Always prompt for download location" preference on Android.
+#if defined(OS_ANDROID)
+  prompt_for_download_.SetValue(false);

[asanka, 2016/10/07 16:10:18]

I don't think we can set the pref without initializing it. And once we do, we
are stuck with the original problem. Doesn't this cause a DCHECK?

[qinmin, 2016/10/07 16:25:14]

Good catch. Switched to always return false in
DownloadTargetDeterminer::ShouldPromptForDownload()

+#else
   prompt_for_download_.Init(prefs::kPromptForDownload, prefs);
+#endif
   download_path_.Init(prefs::kDownloadDefaultDirectory, prefs);
   save_file_path_.Init(prefs::kSaveFileDefaultDirectory, prefs);
   save_file_type_.Init(prefs::kSaveFileType, prefs);