Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 2394303003: Don't prompt for download location on Android (Closed)

Created:
4 years, 2 months ago by qinmin
Modified:
4 years, 2 months ago
Reviewers:
asanka
CC:
asanka, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't prompt for download location on Android On Android, choosing file location is not very user friendly. Disable this for now. BUG=641790 Committed: https://crrev.com/b034f7843cb922da49735428a0aafcb4cf9a3e38 Cr-Commit-Position: refs/heads/master@{#423921}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comments #

Patch Set 3 : disable "save as" tests on android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M chrome/browser/download/chrome_download_manager_delegate_unittest.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/download/download_target_determiner.cc View 1 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 1 2 23 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
qinmin
asanka@, would you please take a quick look so that I can merge this into ...
4 years, 2 months ago (2016-10-06 22:02:57 UTC) #2
asanka
I think we are going to have to address the issue in DownloadTargetDeterminer by unconditionally ...
4 years, 2 months ago (2016-10-07 16:10:18 UTC) #4
qinmin
https://codereview.chromium.org/2394303003/diff/20001/chrome/browser/download/download_prefs.cc File chrome/browser/download/download_prefs.cc (right): https://codereview.chromium.org/2394303003/diff/20001/chrome/browser/download/download_prefs.cc#newcode161 chrome/browser/download/download_prefs.cc:161: prompt_for_download_.SetValue(false); On 2016/10/07 16:10:18, asanka wrote: > I don't ...
4 years, 2 months ago (2016-10-07 16:25:14 UTC) #7
asanka
Code LG, but you'll need to update a few tests in content_unittests. Ping again after ...
4 years, 2 months ago (2016-10-07 16:30:22 UTC) #8
qinmin
On 2016/10/07 16:30:22, asanka wrote: > Code LG, but you'll need to update a few ...
4 years, 2 months ago (2016-10-07 17:59:51 UTC) #9
asanka
lgtm
4 years, 2 months ago (2016-10-07 18:06:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394303003/60001
4 years, 2 months ago (2016-10-07 18:11:16 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 2 months ago (2016-10-07 19:11:32 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 19:14:42 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b034f7843cb922da49735428a0aafcb4cf9a3e38
Cr-Commit-Position: refs/heads/master@{#423921}

Powered by Google App Engine
This is Rietveld 408576698