Don't prompt for download location on Android

Don't prompt for download location on Android

On Android, choosing file location is not very user friendly.
Disable this for now.

BUG=641790
Committed: https://crrev.com/b034f7843cb922da49735428a0aafcb4cf9a3e38
Cr-Commit-Position: refs/heads/master@{#423921}

[qinmin, 2016-10-06 22:02:57]

qinmin@chromium.org changed reviewers:
+ asanka@chromium.org

[qinmin, 2016-10-06 22:02:57]

asanka@, would you please take a quick look so that I can merge this into M54?
Thanks

[qinmin, 2016-10-06 22:13:10]

Patchset #1 (id:1) has been deleted

[asanka, 2016-10-07 16:10:18]

I think we are going to have to address the issue in DownloadTargetDeterminer by
unconditionally returning false from DTD::ShouldPromptForDownload().

https://codereview.chromium.org/2394303003/diff/20001/chrome/browser/download...
File chrome/browser/download/download_prefs.cc (right):

https://codereview.chromium.org/2394303003/diff/20001/chrome/browser/download...
chrome/browser/download/download_prefs.cc:161:
prompt_for_download_.SetValue(false);
I don't think we can set the pref without initializing it. And once we do, we
are stuck with the original problem. Doesn't this cause a DCHECK?

[qinmin, 2016-10-07 16:24:36]

Description was changed from

==========
Ignoring "always prompt for download location" on Android

On Android, choosing file location is not very user friendly.
Disable this for now.

BUG=641790
==========

to

==========
Ignoring "always prompt for download location" on Android

On Android, choosing file location is not very user friendly.
Disable this for now.

BUG=641790
==========

[qinmin, 2016-10-07 16:24:48]

Description was changed from

==========
Ignoring "always prompt for download location" on Android

On Android, choosing file location is not very user friendly.
Disable this for now.

BUG=641790
==========

to

==========
Don't prompt for download location on Android

On Android, choosing file location is not very user friendly.
Disable this for now.

BUG=641790
==========

[qinmin, 2016-10-07 16:25:14]

https://codereview.chromium.org/2394303003/diff/20001/chrome/browser/download...
File chrome/browser/download/download_prefs.cc (right):

https://codereview.chromium.org/2394303003/diff/20001/chrome/browser/download...
chrome/browser/download/download_prefs.cc:161:
prompt_for_download_.SetValue(false);
On 2016/10/07 16:10:18, asanka wrote:
> I don't think we can set the pref without initializing it. And once we do, we
> are stuck with the original problem. Doesn't this cause a DCHECK?

Good catch. Switched to always return false in
DownloadTargetDeterminer::ShouldPromptForDownload()

[asanka, 2016-10-07 16:30:22]

Code LG, but you'll need to update a few tests in content_unittests. Ping again
after checking?

[qinmin, 2016-10-07 17:59:51]

On 2016/10/07 16:30:22, asanka wrote:
> Code LG, but you'll need to update a few tests in content_unittests. Ping
again
> after checking?

Done. PTAL again.

Disabled the failing tests as they are all fall into the "save as" category,
which doesn't apply on android.

[asanka, 2016-10-07 18:06:39]

lgtm

[qinmin, 2016-10-07 18:10:39]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2016-10-07 18:11:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 19:11:31]

Description was changed from

==========
Don't prompt for download location on Android

On Android, choosing file location is not very user friendly.
Disable this for now.

BUG=641790
==========

to

==========
Don't prompt for download location on Android

On Android, choosing file location is not very user friendly.
Disable this for now.

BUG=641790
==========

[commit-bot: I haz the power, 2016-10-07 19:11:32]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-10-07 19:14:41]

Description was changed from

==========
Don't prompt for download location on Android

On Android, choosing file location is not very user friendly.
Disable this for now.

BUG=641790
==========

to

==========
Don't prompt for download location on Android

On Android, choosing file location is not very user friendly.
Disable this for now.

BUG=641790

Committed: https://crrev.com/b034f7843cb922da49735428a0aafcb4cf9a3e38
Cr-Commit-Position: refs/heads/master@{#423921}
==========

[commit-bot: I haz the power, 2016-10-07 19:14:42]

Patchset 3 (id:??) landed as
https://crrev.com/b034f7843cb922da49735428a0aafcb4cf9a3e38
Cr-Commit-Position: refs/heads/master@{#423921}