Issue 23943004: Support Page.getNavigationHistory and Page.navigateToHistoryEntry in RendererOverridesHandler

Issue 23943004: Support Page.getNavigationHistory and Page.navigateToHistoryEntry in RendererOverridesHandler (Closed)

Created:
7 years, 3 months ago by Vladislav Kaznacheev

Modified:
7 years, 3 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Support Page.getNavigationHistory and Page.navigateToHistoryEntry in RendererOverridesHandler BUG=285169 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221763

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Using unique entry id instead of index #

Total comments: 2

Patch Set 4 : Addressed comments #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -0 lines)			Patch
M	content/browser/devtools/devtools_protocol_constants.h	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	content/browser/devtools/devtools_protocol_constants.cc	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	content/browser/devtools/renderer_overrides_handler.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/devtools/renderer_overrides_handler.cc	View	1 2 3	3 chunks	+75 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/23943004/diff/6001/content/browser/devtools/renderer_overrides_handler.cc File content/browser/devtools/renderer_overrides_handler.cc (right): https://codereview.chromium.org/23943004/diff/6001/content/browser/devtools/renderer_overrides_handler.cc#newcode371 content/browser/devtools/renderer_overrides_handler.cc:371: return command->InternalErrorResponse("History entry not found"); InvalidParameter

7 years, 3 months ago (2013-09-06 13:08:50 UTC) #2

Vladislav Kaznacheev

https://codereview.chromium.org/23943004/diff/6001/content/browser/devtools/renderer_overrides_handler.cc File content/browser/devtools/renderer_overrides_handler.cc (right): https://codereview.chromium.org/23943004/diff/6001/content/browser/devtools/renderer_overrides_handler.cc#newcode371 content/browser/devtools/renderer_overrides_handler.cc:371: return command->InternalErrorResponse("History entry not found"); On 2013/09/06 13:08:51, pfeldman ...

7 years, 3 months ago (2013-09-06 13:50:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/23943004/10001

7 years, 3 months ago (2013-09-06 13:50:52 UTC) #4

Message was sent while issue was closed.

Change committed as 221763

Expand Messages | Collapse Messages