third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 2394273006: Add CSS support for text-decoration-skip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2394273006: Add CSS support for text-decoration-skip (Closed)

Patch Set: Basic test for parsing, readback and inheritance added Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index 12e6b65913f6a082e81a0f28a4257456900584ed..93cf07919c6203fe7d724c1a5725137dea53dd83 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -1106,6 +1106,8 @@ void ComputedStyle::updatePropertySpecificDifferences(

other.m_rareInheritedData->visitedLinkTextEmphasisColor() ||

m_rareInheritedData->textEmphasisFill !=

other.m_rareInheritedData->textEmphasisFill ||

+ m_rareInheritedData->m_textDecorationSkip !=

+ other.m_rareInheritedData->m_textDecorationSkip ||

m_rareInheritedData->appliedTextDecorations !=

other.m_rareInheritedData->appliedTextDecorations)) {

diff.setTextDecorationOrColorChanged();