Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2394273003: Revert of [Cast, Tests] Handle low end and JB devices that don't preload videos (Closed)

Created:
4 years, 2 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Cast, Tests] Handle low end and JB devices that don't preload videos (patchset #1 id:1 of https://codereview.chromium.org/2400543002/ ) Reason for revert: Speculative revert because cast tests started flaking very heavily at this revision and it's effectively blocking things in the CQ. See https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng?numbuilds=200 for example failures Original issue's description: > [Cast, Tests] Handle low end and JB devices that don't preload videos > > BUG=652872, 652389 > TEST=run_chrome_public_test_apk --verbose --gtest_filter=org.chromium.chrome.browser.media.remote.* on both low end and not a low end device. > > Since https://codereview.chromium.org/2344353003 on low-end and JB devices videos > are not preloaded so we have to trigger that in a button onclick handler. > > Committed: https://crrev.com/6e5b06e0201d483a1596aedf438fb931fbbe7b42 > Cr-Commit-Position: refs/heads/master@{#423775} TBR=mlamouri@chromium.org,avayvod@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=652872, 652389 Committed: https://crrev.com/680764f10bc0dc6f8aa7bfaef566b685983599cd Cr-Commit-Position: refs/heads/master@{#423799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastSwitchVideoTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/android/media/simple_video.html View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/data/android/media/simple_video2.html View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/data/android/media/two_videos.html View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ken Rockot(use gerrit already)
Created Revert of [Cast, Tests] Handle low end and JB devices that don't preload videos
4 years, 2 months ago (2016-10-07 05:21:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394273003/1
4 years, 2 months ago (2016-10-07 05:21:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 05:23:17 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 05:25:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/680764f10bc0dc6f8aa7bfaef566b685983599cd
Cr-Commit-Position: refs/heads/master@{#423799}

Powered by Google App Engine
This is Rietveld 408576698